-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin execution #980
Merged
Merged
Plugin execution #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return gmeAuth.getProjectAuthorizationByUserId(params.username, params.projectId); | ||
}) | ||
.then(function (access) { | ||
logger.info('User has the following writes to the project: ', access); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writes -> rights
InterpreterManager turning into PluginUtil.
TODO: Fix the pluginConfigDialog.
TODO: Add tests for this.
PluginBase.isMetaType of should account for mixins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change is that plugins are now required to have an associated
metadata.json
and the execution of browser plugins (once configured) are now handled by the client.This PR deals with the following:
this.META
within the plugin can be configured to contain only nodes under a given namespace (within a library). This allows the meta helpers function on PluginBase to adapt to the namespace.requiresWriteAccess
- which prohibits execution of a plugin if the invoker does not have write access to the project. (The UI disables these plugins and the plugin manager throws an error if requirement not met.)requiresWriteAccess
. They are handled in the same way as above. (readOnly
parameters are ensured to not be overwritten by the users too.)runBrowserPlugin
with the same parameters asrunServerPlugin
.