Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin execution #980

Merged
merged 22 commits into from
May 2, 2016
Merged

Plugin execution #980

merged 22 commits into from
May 2, 2016

Conversation

pmeijer
Copy link
Contributor

@pmeijer pmeijer commented Apr 27, 2016

The breaking change is that plugins are now required to have an associated metadata.json and the execution of browser plugins (once configured) are now handled by the client.

This PR deals with the following:

  • Enables plugins to be executed under a namespace, i.e. the this.META within the plugin can be configured to contain only nodes under a given namespace (within a library). This allows the meta helpers function on PluginBase to adapt to the namespace.
  • Plugin metadata introduces new key requiresWriteAccess - which prohibits execution of a plugin if the invoker does not have write access to the project. (The UI disables these plugins and the plugin manager throws an error if requirement not met.)
  • Plugin configuration parameters are also extend with requiresWriteAccess. They are handled in the same way as above. (readOnly parameters are ensured to not be overwritten by the users too.)
  • Execution of plugins in the browser share the same code base as for the server execution. Additionally there is no need to use the InterpreterManager anymore (it is still there but only deals with configuring plugins) - instead the client has a method runBrowserPlugin with the same parameters as runServerPlugin.

return gmeAuth.getProjectAuthorizationByUserId(params.username, params.projectId);
})
.then(function (access) {
logger.info('User has the following writes to the project: ', access);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writes -> rights

pmeijer pushed a commit that referenced this pull request May 1, 2016
@kecso kecso merged commit 2cb4c95 into master May 2, 2016
@pmeijer pmeijer deleted the plugin_execution branch May 2, 2016 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants