New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Migrate brotli to built-in implementation #1604
Comments
Looks like 10.16.0 is going to have brotli built-in as well 馃帀 I'm seriously thinking about dropping support for node 8 just because of this... It will solve a few of the binary issues people are having. |
These are the current dates for the node versions:
Even though v8 EOL is 2019-12-31 I believe we should target November ourselves and remove brotli at the same time. |
I don't think we need to wait until v8 EOL, the sooner we migrate to v10, the better. |
Agree with the sentiment we shouldn't wait on this. Binary dependencies have been a consistent pain so the sooner we eliminate them the better our overall install experience will be (assuming we also eliminate Plus we already have dependencies that ask for v10 plus. They still work on v8 for the moment using |
Working on this right now. |
馃殌 Feature request
Description
Node will soon have built-in support for brotli per:
nodejs/node#24938
https://twitter.com/addaleax/status/1081653502693257217?s=21
It will be great to migrate our usage to this version.
We will have to see where it lands (node 11 or maybe it gets back ported) and work on a planif it gets back ported to previos versions of node and if not work on a plan to remove our current dependencies in favor of this one.
Are you willing to work on this?Yup
What scenarios will this solve?
Less dependencies to download and keep up to date. Also we had problems with the binaries in the past so less risk.
The text was updated successfully, but these errors were encountered: