Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Migrate brotli to built-in implementation #1604

Closed
molant opened this issue Jan 6, 2019 · 5 comments
Closed

[Feature] Migrate brotli to built-in implementation #1604

molant opened this issue Jan 6, 2019 · 5 comments
Assignees
Milestone

Comments

@molant
Copy link
Member

molant commented Jan 6, 2019

馃殌 Feature request

Description

Node will soon have built-in support for brotli per:
nodejs/node#24938
https://twitter.com/addaleax/status/1081653502693257217?s=21

It will be great to migrate our usage to this version.

We will have to see where it lands (node 11 or maybe it gets back ported) and work on a planif it gets back ported to previos versions of node and if not work on a plan to remove our current dependencies in favor of this one.

Are you willing to work on this?

Yup

What scenarios will this solve?

Less dependencies to download and keep up to date. Also we had problems with the binaries in the past so less risk.

@molant
Copy link
Member Author

molant commented May 16, 2019

Looks like 10.16.0 is going to have brotli built-in as well 馃帀
https://twitter.com/mylesborins/status/1128874489180315648?s=21

I'm seriously thinking about dropping support for node 8 just because of this... It will solve a few of the binary issues people are having.

@molant
Copy link
Member Author

molant commented Oct 2, 2019

These are the current dates for the node versions:

Release Status Initial Release Active LTS Start Maintenance LTS Start End-of-life
v8 Maintenance LTS 2017-05-30 2017-10-31 2019-01-01 2019-12-31
v10 Active LTS 2018-04-24 2018-10-30 2020-04-01 2021-04-01
v12 Current 2019-04-23 2019-10-22 2021-04-01 2022-04-01

Even though v8 EOL is 2019-12-31 I believe we should target November ourselves and remove brotli at the same time.

@sarvaje @antross thoughts?

@sarvaje
Copy link
Contributor

sarvaje commented Oct 2, 2019

I don't think we need to wait until v8 EOL, the sooner we migrate to v10, the better.

@antross
Copy link
Member

antross commented Oct 3, 2019

Agree with the sentiment we shouldn't wait on this.

Binary dependencies have been a consistent pain so the sooner we eliminate them the better our overall install experience will be (assuming we also eliminate canvas).

Plus we already have dependencies that ask for v10 plus. They still work on v8 for the moment using --ignore-engines, but who knows how long that will last.

@molant
Copy link
Member Author

molant commented Oct 18, 2019

Working on this right now.
Will also update docs to say to use node 10, etc.

molant added a commit to molant/hint that referenced this issue Oct 18, 2019
@molant molant mentioned this issue Oct 18, 2019
2 tasks
molant added a commit to molant/hint that referenced this issue Oct 21, 2019
@molant molant modified the milestones: 1910-2, 1911-1 Oct 25, 2019
molant added a commit to molant/hint that referenced this issue Oct 31, 2019
@molant molant modified the milestones: 1911-1, 1911-2 Nov 11, 2019
molant added a commit to molant/hint that referenced this issue Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants