Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide configuration-all from the user #3367

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

molant
Copy link
Member

@molant molant commented Nov 18, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

This configuration is only for internal consumption to get easy access
to all the documentation and should never be used by a user as it can
cause problems when extending from it.

This PR filters it when running npm init hintrc and verifies the
.hintrc doesn't extends from it.


Fix #3097

This configuration is only for internal consumption to get easy access
to all the documentation and should never be used by a user as it can
cause problems when extending from it.

This PR filters it when running `npm init hintrc` and verifies the
`.hintrc` doesn't `extends` from it.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#3097
@molant
Copy link
Member Author

molant commented Nov 18, 2019

macOS is failing because there's a new version of Chrome and the cask checksum hasn't been updated yet.

@molant molant merged commit b628eb4 into webhintio:master Nov 19, 2019
@molant molant deleted the fix/hide-config-all branch March 7, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide configuration-all from create packages and website
2 participants