-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added page content and styles #7
Conversation
qzhou1607-zz
commented
Apr 28, 2017
- Homepage
- Developer Guide
- User Guide
- Adjust styles to fit contents generated from markdown
- Update TOC structure
9fa1b33
to
06d1944
Compare
Got the PR and pulled it locally. Will look on Monday as it’s time to pick up Oz. |
Great, thanks a lot! Have a great weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if all the things in the PR will be used, but will see as we go along, and remove what turns out to not be needed.
<div class="home-container--input"> | ||
<form action="/scanner" method="POST"> | ||
<label for="home-scan">Scan your website for errors...</label> | ||
<input id="home-scan" type="url" placeholder="Copy your URL here" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use: Enter your URL here
.
color: #767676; | ||
|
||
/* Move up 1/2 height of icon to make it exactly in middle */ | ||
-webkit-transform: translateY(-50%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not important right now, but in the future, when we get to improve the build step, we should use something like autoprefixer
.
.highlight { | ||
border: 2px solid hsla(0, 0%, 0%, .03); | ||
background: hsla(0, 0%, 0%, .03); | ||
margin-top: 2.4rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent is not consistent.
|
||
|
||
/* | ||
* GITHUB GIST OVERRIDES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not (and probably won't be) using GitHub gists, so this section can be removed.
|
||
margin: 0 auto; | ||
|
||
font-family: 'Montserrat', sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent is not consistent.
/* | ||
* ACCORDIONS | ||
* ============================================= | ||
* @Dependencies: base.css, icons.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove icons.css
as we don't include that file.
/* | ||
* Menu Button | ||
* ============================================= | ||
* @Dependencies: base.css, type.css, icons.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove icons.css
as we don't include that file.
/* | ||
* Pagination | ||
* ============================================= | ||
* @Dependencies: base.css, type.css, icons.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove icons.css
as we don't include that file.
|
||
padding: 1.2rem; | ||
|
||
font: 2.4rem/1 PlatformIcons; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlatformIcons
font is not included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ststimac I don't think we are using platformIcons
or any style inside anchor-top.css
. Should I just remove the file entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove any reference to platform icons.
We may use the anchor-top.css on the results page so leave the rest of it. I haven't finished updating styles/CSS code.
*/ | ||
|
||
.table-of-contents > ul { | ||
margin-top: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent is not consistent with the one used in the other files.
2dd00f7
to
c1f5a1d
Compare
@qzhou1607 @ststimac let me know when this is ready for another review. |
@molant my review is done, I'll be providing updated SVGs outside of this PR. |
0bf5176
to
008589a
Compare
008589a
to
726773f
Compare
Looks @qzhou1607 has addressed most of the feedback and @ststimac will update the svgs via another PR once this is merged. Merging and closing! |