Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@qzhou1607-zz
qzhou1607-zz committed May 1, 2017
1 parent 06d1944 commit 2dd00f7
Show file tree
Hide file tree
Showing 17 changed files with 221 additions and 259 deletions.
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/disallowed-headers.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: disallowed-headers
toc-title: rules
permalink: /docs/user-guide/rules/disallowed-headers.html
permalink: docs/user-guide/rules/disallowed-headers.html
---
# Disallow certain HTTP headers (`disallow-headers`)

Expand Down
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/lang-attribute.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: lang-attribute
toc-title: rules
permalink: /docs/user-guide/rules/lang-attribute.html
permalink: docs/user-guide/rules/lang-attribute.html
---
# Require `lang` attribute on the `html` element (`lang-attribute`)

Expand Down
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/manifest-exists.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: manifest-exists
toc-title: rules
permalink: /docs/user-guide/rules/manifest-exists.html
permalink: docs/user-guide/rules/manifest-exists.html
---
# Require a web app manifest file (`manifest-exists`)

Expand Down
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/manifest-file-extension.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: manifest-file-extension
toc-title: rules
permalink: /docs/user-guide/rules/manifest-file-extension.html
permalink: docs/user-guide/rules/manifest-file-extension.html
---
# Disallow non-standard file extension for the web app manifest file (`manifest-file-extension`)

Expand Down
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/no-friendly-error-pages.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: no-friendly-error-pages
toc-title: rules
permalink: /docs/user-guide/rules/no-friendly-error-pages.html
permalink: docs/user-guide/rules/no-friendly-error-pages.html
---
# Disallow small error pages (`no-friendly-error-pages`)

Expand Down
2 changes: 1 addition & 1 deletion source/docs/user-guide/rules/no-html-only-headers.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
category: user-guide
title: no-html-only-headers
toc-title: rules
permalink: /docs/user-guide/rules/no-html-only-headers.html
permalink: docs/user-guide/rules/no-html-only-headers.html
---
# Disallow unneeded HTTP headers for non-HTML resources (`no-html-only-headers`)

Expand Down
19 changes: 10 additions & 9 deletions themes/documentation/layout/index.hbs
View file
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
<!DOCTYPE html>
<html lang="en-US">
<html lang="en">

<head>
<meta charset="utf-8">
<title>Sonar</title>
<meta name="description" content="css grid experiments">
<meta name="description" content="sonar website">
<meta name="viewport" content="width=device-width">

<link rel="stylesheet" href="{{url_for "core/css/base.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/color.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/layouts.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/navigation.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/structure.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/type.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/base.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/color.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/layouts.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/navigation.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/structure.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/type.css"}}">
<link rel="stylesheet" href="{{url_for "components/breadcrumb/breadcrumb.css"}}">
{{#if isScanner}}
<link rel="stylesheet" href="{{url_for "core/css/controls.css "}}">
<link rel="stylesheet" href="{{url_for "core/css/controls.css"}}">
<link rel="stylesheet" href="{{url_for "core/css/home.css"}}">
{{else}}
<link rel="stylesheet" href="{{url_for "core/css/code.css"}}">
Expand Down
6 changes: 3 additions & 3 deletions themes/documentation/layout/partials/scan-form.hbs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<article>
<section class="container">
<div class="top-illustration">
<img src="{{url_for " images/iceberg-left.svg "}}" class="iceberg" id="iceberg1" />
<img src="{{url_for " images/iceberg-middle.svg "}}" class="iceberg" id="iceberg2" />
<img src="{{url_for "images/iceberg-left.svg"}}" class="iceberg" id="iceberg1" />
<img src="{{url_for "images/iceberg-middle.svg"}}" class="iceberg" id="iceberg2" />
<img src="" class="iceberg iceberg3" />
<div id="narwhal">
<img src="" class="narwhal" />
Expand All @@ -14,7 +14,7 @@
<div class="container home-container">
<div class="home-container--input">
<form action="/scanner" method="POST">
<label for="home-scan">Scan your website for errors...</label>
<label for="home-scan">Enter your URL here</label>
<input id="home-scan" type="url" placeholder="Copy your URL here" />
<button type="submit">Run Scan</button>
</form>
Expand Down
4 changes: 2 additions & 2 deletions themes/documentation/source/components/accordion/accordion.css
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* ACCORDIONS
* =============================================
* @Dependencies: base.css, icons.css
* @Dependencies: base.css
*/

summary {
Expand Down Expand Up @@ -60,4 +60,4 @@ details > div {

details[open] > div {
display: block;
}
}
4 changes: 2 additions & 2 deletions themes/documentation/source/components/menu-button/menu-button.css
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Menu Button
* =============================================
* @Dependencies: base.css, type.css, icons.css
* @Dependencies: base.css, type.css
* 3 levels of selectors for menu items ensure that
* this component is supported whether or not the
* browser supports button[type="menu"] (needed
Expand Down Expand Up @@ -134,4 +134,4 @@ button[type="menu"] + [role="menu"] label {
button[type="submit"] + [role="menu"] input:focus + label,
button[type="menu"] + [role="menu"] input:focus + label {
outline: 1px dashed #000;
}
}
4 changes: 2 additions & 2 deletions themes/documentation/source/components/pagination/pagination.css
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Pagination
* =============================================
* @Dependencies: base.css, type.css, icons.css
* @Dependencies: base.css, type.css
*/

.pagination {
Expand Down Expand Up @@ -114,4 +114,4 @@
color: buttonText;
}

}
}
15 changes: 0 additions & 15 deletions themes/documentation/source/core/css/code.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,3 @@ code {
-moz-tab-size: 4;
tab-size: 4;
}


/*
* GITHUB GIST OVERRIDES
* ---------------------------------------------
*/

.gist-file {
border-width: 2px;
border-bottom: 2px solid #ddd;
}

.gist-data {
border-bottom-width: 2px;
}
24 changes: 0 additions & 24 deletions themes/documentation/source/core/css/fonts.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,3 @@
url("") format("woff");
font-weight: 400;
}

@font-face {
font-family: 'Montserrat';
src: local("Montserrat Light"),
url("") format("woff2"),
url("") format("woff");
font-weight: 300;
}

@font-face {
font-family: 'Montserrat';
src: local("Montserrat Regular"),
url("") format("woff2"),
url("") format("woff");
font-weight: 400;
}

@font-face {
font-family: 'Montserrat';
src: local("Montserrat Medium"),
url("") format("woff2"),
url("") format("woff");
font-weight: 600;
}
48 changes: 24 additions & 24 deletions themes/documentation/source/core/css/home.css
View file
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
/*
* HOME PAGE
* =============================================
*/
* HOME PAGE
* =============================================
*/

body {
background-color: #4046dd;
color: #fff;
background-color: #4046dd;
color: #fff;
}

.top-illustration {
position: relative;
height: 15.7rem;
z-index: -100;
position: relative;
height: 15.7rem;
z-index: -100;
}

#iceberg1 {
position: relative;
width: 25rem;
position: relative;
width: 25rem;

animation: floating 4s infinite normal ease-out;
animation: floating 4s infinite normal ease-out;
}

#iceberg2 {
position: absolute;
margin-top: 11rem;
margin-left: 15rem;
width: 15rem;
position: absolute;
margin-top: 11rem;
margin-left: 15rem;
width: 15rem;

animation: floating 5s infinite 2s normal ease-out;
animation: floating 5s infinite 2s normal ease-out;
}

@keyframes floating {
Expand All @@ -37,7 +37,7 @@ body {
}

50% {
top: 0px;
top: 0px;
}

100% {
Expand All @@ -46,17 +46,17 @@ body {
}

.home-container {
margin: 0 auto;
padding: 4rem 2rem;
margin: 0 auto;
padding: 4rem 2rem;
}

.home-container--input {
margin: 0 auto;
width: 96rem;
margin: 0 auto;
width: 96rem;
}

.dark-blue {
background-color: rgba(24,24,109,0.9);
min-height: 65rem;
z-index: 100;
background-color: rgba(24,24,109,0.9);
min-height: 65rem;
z-index: 100;
}
Loading

0 comments on commit 2dd00f7

Please sign in to comment.