Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintian messages #37

Closed
bahamat opened this issue Oct 18, 2013 · 13 comments
Closed

Lintian messages #37

bahamat opened this issue Oct 18, 2013 · 13 comments
Assignees
Labels
Milestone

Comments

@bahamat
Copy link
Contributor

bahamat commented Oct 18, 2013

This issue will track overall progress on Lintian messages.

Current output:

N: Processing binary package cfengine3 (version 3.5.2-1+nmu1, arch amd64) ...
W: cfengine3: package-name-doesnt-match-sonames libpromises3
I: cfengine3: spelling-error-in-binary usr/lib/libpromises.so.3.0.5 deamon daemon
I: cfengine3: spelling-error-in-binary usr/lib/libpromises.so.3.0.5 Commerical Commercial
I: cfengine3: spelling-error-in-binary usr/lib/libpromises.so.3.0.5 avaiable available
W: cfengine3: hardening-no-relro usr/lib/libpromises.so.3.0.5
W: cfengine3: hardening-no-fortify-functions usr/lib/libpromises.so.3.0.5
W: cfengine3: hardening-no-relro usr/sbin/cf-agent
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-agent
W: cfengine3: hardening-no-relro usr/sbin/cf-execd
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-execd
W: cfengine3: hardening-no-relro usr/sbin/cf-key
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-key
W: cfengine3: hardening-no-relro usr/sbin/cf-monitord
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-monitord
W: cfengine3: hardening-no-relro usr/sbin/cf-promises
I: cfengine3: spelling-error-in-binary usr/sbin/cf-runagent overriden overridden
W: cfengine3: hardening-no-relro usr/sbin/cf-runagent
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-runagent
W: cfengine3: hardening-no-relro usr/sbin/cf-serverd
W: cfengine3: hardening-no-fortify-functions usr/sbin/cf-serverd
W: cfengine3: hardening-no-relro usr/sbin/rpmvercmp
W: cfengine3: binary-without-manpage usr/sbin/cf-agent
W: cfengine3: binary-without-manpage usr/sbin/cf-execd
W: cfengine3: binary-without-manpage usr/sbin/cf-key
W: cfengine3: binary-without-manpage usr/sbin/cf-monitord
W: cfengine3: binary-without-manpage usr/sbin/cf-promises
W: cfengine3: binary-without-manpage usr/sbin/cf-runagent
W: cfengine3: binary-without-manpage usr/sbin/cf-serverd
W: cfengine3: binary-without-manpage usr/sbin/rpmvercmp
W: cfengine3: non-dev-pkg-with-shlib-symlink usr/lib/libpromises.so.3.0.5 usr/lib/libpromises.so
I: cfengine3: no-symbols-control-file usr/lib/libpromises.so.3.0.5
N: 1 tag overridden (1 info)
@bahamat
Copy link
Contributor Author

bahamat commented Oct 20, 2013

Commit a2b79ae cleaned up a lot of these messages.

Current lintian status:

N: Processing binary package cfengine3 (version 3.5.2-1+nmu1, arch amd64) ...
W: cfengine3: package-name-doesnt-match-sonames libpromises3
W: cfengine3: binary-without-manpage usr/sbin/cf-agent
W: cfengine3: binary-without-manpage usr/sbin/cf-execd
W: cfengine3: binary-without-manpage usr/sbin/cf-key
W: cfengine3: binary-without-manpage usr/sbin/cf-monitord
W: cfengine3: binary-without-manpage usr/sbin/cf-promises
W: cfengine3: binary-without-manpage usr/sbin/cf-runagent
W: cfengine3: binary-without-manpage usr/sbin/cf-serverd
W: cfengine3: binary-without-manpage usr/sbin/rpmvercmp
W: cfengine3: non-dev-pkg-with-shlib-symlink usr/lib/libpromises.so.3.0.5 usr/lib/libpromises.so
I: cfengine3: no-symbols-control-file usr/lib/libpromises.so.3.0.5
N: 1 tag overridden (1 info)

@bahamat
Copy link
Contributor Author

bahamat commented Oct 21, 2013

Current lintian status:

N: Processing binary package cfengine3 (version 3.5.2-1+nmu1, arch amd64) ...
W: cfengine3: package-name-doesnt-match-sonames libpromises3
W: cfengine3: binary-without-manpage usr/sbin/cf-agent
W: cfengine3: binary-without-manpage usr/sbin/cf-execd
W: cfengine3: binary-without-manpage usr/sbin/cf-key
W: cfengine3: binary-without-manpage usr/sbin/cf-monitord
W: cfengine3: binary-without-manpage usr/sbin/cf-promises
W: cfengine3: binary-without-manpage usr/sbin/cf-runagent
W: cfengine3: binary-without-manpage usr/sbin/cf-serverd
W: cfengine3: binary-without-manpage usr/sbin/rpmvercmp
W: cfengine3: non-dev-pkg-with-shlib-symlink usr/lib/libpromises.so.3.0.5 usr/lib/libpromises.so
N: 1 tag overridden (1 info)

@tzz
Copy link
Collaborator

tzz commented Nov 5, 2013

Can I assume the lintian errors are due to #40 ?

I don't think we can fix the soname, libpromises is pretty fundamental to CFEngine.

The last warning seems weird. Isn't that how you're supposed to install libraries? Or am I misunderstanding something?

@bahamat
Copy link
Contributor Author

bahamat commented Nov 5, 2013

I think it's important to include the man pages.

For the other two, I think Debian's recomendation is that cfengine3 should be split into two separate packages. One package would be libpromises, and contain only the libpromises stuff. The second would be cfengine3 which depends on libpomises.

How crazy would it be to split it like that? If it's trivial, or very easy then I guess, why not? But if it's anything more than trivial or very easy then I would rather just override the warnings and ignore it.

@bahamat
Copy link
Contributor Author

bahamat commented Nov 5, 2013

Also, for reference, Lintian has (at least) four types of messages. Notice, info, warning and errors.

We've never had any lintian errors, they've always been at warning or below.

@basvandervlies
Copy link
Collaborator

@tzz, @bahamat we can also switch to static binaries then this warning will disappear. But then we can not use the cfe-profiler.

@bahamat
Copy link
Contributor Author

bahamat commented Nov 6, 2013

I'd like to have the option of using the profiler. There are lots of other debian packages that squelch or do nothing about each of these messages, so I'm fine doing that as well, unless there's strong objection raised by Debian.

@basvandervlies
Copy link
Collaborator

@bahamat +1

@tzz
Copy link
Collaborator

tzz commented Nov 6, 2013

Splitting off libpromises for the sake of a warning is IMO not worth the effort, so I'll go with @bahamat

@ghost ghost assigned bahamat Nov 6, 2013
@bahamat
Copy link
Contributor Author

bahamat commented Nov 6, 2013

In that case I'm assigning to myself and I'll configure a lintian override for those two messages.

@bahamat
Copy link
Contributor Author

bahamat commented Nov 12, 2013

I've now merged in a new override that takes care of both of the libpromises messages. The last thing is the man pages then it'll be done.

Ted had a good idea for creating a new acceptance test that produces the man pages. I'll use that as a last resort if I can't do it directly in debian/rules.

@tzz
Copy link
Collaborator

tzz commented Nov 12, 2013

I commented in cfengine/core#1059 and cfengine/core#1037 as well because they seem to be blocking each other to block the @basvandervlies patch.

@bahamat
Copy link
Contributor Author

bahamat commented Nov 12, 2013

Since the only thing left is the missing man pages #40 specifically addresses that, I think this issue can be considered closed.

@bahamat bahamat closed this as completed Nov 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants