fix(api-aco): ensure correct tenant and locale is used in ACO storage #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue that can be encountered in multi-tenant systems, when switching tenants programmatically, and creating Pages via code. The issue is that the internal storage model is always assigned the original tenant/locale which was used in the original request, which bootstrapped the system. Subsequent changes of tenants or locales would not get propagated to the storage model, resulting in search records being stored in the wrong tenant.
How Has This Been Tested?
Manually, by using a custom plugin provided by a customer.