Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-file-manager): prevent bulk edit dialog dismiss #3790

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Jan 3, 2024

Changes

With this PR, clicking outside the "Bulk edit - dialog" no longer dismisses it.

How Has This Been Tested?

Manually

Documentation

How to replicate the bug:

Register a new extension field that renders a new custom dialog.

  • Select one or more files from the File Manager list
  • Click on the "Edit" action
  • Select the field -> "Override existing values" -> Click to open the new dialog
  • Click outside the custom dialog: both the custom dialog and the "Bulk Edit" dialog close.
CleanShot.2024-01-03.at.15.00.41.mp4

@leopuleo leopuleo changed the base branch from next to dev January 3, 2024 14:07
@leopuleo leopuleo added this to the 5.38.3 milestone Jan 3, 2024
@leopuleo leopuleo self-assigned this Jan 3, 2024
@leopuleo leopuleo marked this pull request as ready for review January 3, 2024 16:14
@leopuleo leopuleo requested a review from Pavel910 January 3, 2024 16:14
@leopuleo leopuleo merged commit e16899c into dev Jan 4, 2024
78 checks passed
@leopuleo leopuleo deleted the leo/fix/fm-bulk-edit-dialog-dismiss branch January 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants