Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-headless-cms): rename deleted flag to wbyDeleted #4087

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

leopuleo
Copy link
Contributor

Changes

With this PR, we rename the newly created deleted flag to wbyDeleted. This is necessary to avoid conflicting with user-defined 'deleted' fields by treating wby as a reserved field.

How Has This Been Tested?

Jest + manually

Documentation

We need to highlight the newly created field (wbyDeleted) inside the release docs.

@leopuleo leopuleo added this to the 5.40.0 milestone Apr 18, 2024
@leopuleo leopuleo self-assigned this Apr 18, 2024
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just renames, so I think this is ok.

@leopuleo leopuleo merged commit 42fcc1a into next Apr 22, 2024
87 checks passed
@leopuleo leopuleo deleted the leo/fix/hcms-trash-bin-deleted-flag branch June 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants