Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.40.0 Fixes - Batch 1 #4119

Merged
merged 15 commits into from
May 15, 2024
Merged

5.40.0 Fixes - Batch 1 #4119

merged 15 commits into from
May 15, 2024

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented May 8, 2024

Changes

This PR includes a couple of polishes for the 5.40.0 release.

1. Added README.md In the New extensions Folder

For better UX, the extensions folder will now also include a short README file, just so it's easier for users to know what the folder is and how to get started with creating a new extension.

2. Deployment Logs Always Included In CI

With 5.40.0, deployment logs are automatically hidden. But, most probably, this should not be happening in CI environments. So, we ensured that the logs are always shown in CI environments.

3. Deployments - allow-local-state-files Flag

When deploying into production environment, an error will be thrown if the user is using local state files. This is simply because it's not recommended. Still, if the uses wishes to ignore the error, they can do it by passing the allow-local-state-files flag.

4. Extensions Scaffolds - Updating Dependencies In package.json

When using the API / Admin scaffolds, respectively, the apps/api/graphql/package.json and apps/admin/package.json are now updated with the new package that was created in the process. Previously this wasn't the case.

5. Extensions Scaffolds - Added --dependencies Parameter

When running the scaffold command in a non-interactive mode, users also now have the ability to pass the --dependencies flag in order to immediately add required dependencies in the new extension's package.json. For example:

yarn webiny scaffold new-extension --type admin --name customFilePreview --dependencies @webiny/app-serverless-cms

Multiple dependencies can also be added, by separating them with a comma, for example:

--dependencies @webiny/app-serverless-cms,@webiny/app-file-manager

6. @webiny/pulumi-aws - DEFAULT_PROD_ENV_NAMES Constant

Throughout multiple files, we had the following line of code:

const productionEnvironments = app.params.create.productionEnvironments || ["prod"];

For easier maintenance, the DEFAULT_PROD_ENV_NAMES constant was introduced, and the above line has now been changed to:

const productionEnvironments = app.params.create.productionEnvironments || DEFAULT_PROD_ENV_NAMES;

6. @webiny/ui - Removed import "@rmwc/chip/styles"; Import

We've noticed Webpack reporting a weird error upon building both Admin and Website apps:

image

After investigation, we've detected that it's because of the import "@rmwc/chip/styles"; statement in the packages/ui/src/Chips/Chips.tsx file. Removing it resolved the issue, and, most importantly, did not cause any visual regressions with the component.

7. dynamoDbElasticsearchTable No Longer Present In DDB-Only Projects

The dynamoDbElasticsearchTable property would always be included when deploying the API app, both in DDB-only and DDB+ES projects.

Although it wasn't making any serious issues, when deploying a DDB-only project, a warning from Pulumi would be printed out.

image

With this minor fix, this is no longer the case.

How Has This Been Tested?

Manually.

Documentation

Changelog.

@adrians5j
Copy link
Member Author

/cypress

Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@adrians5j
Copy link
Member Author

/cypress

Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@adrians5j adrians5j marked this pull request as ready for review May 13, 2024 08:44
@adrians5j adrians5j added this to the 5.40.0 milestone May 13, 2024
@adrians5j
Copy link
Member Author

Went through this changes with @Pavel910.

@adrians5j adrians5j merged commit e803c06 into next May 15, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant