-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.40.0 Fixes - Batch 1 #4119
Merged
Merged
5.40.0 Fixes - Batch 1 #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arg makes it a bit easier to immediately add initial dependencies (if the user knows them).
May help with ensuring all of the files/folders are ready for yarn.
….40-fixes-batch-1
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Went through this changes with @Pavel910. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes a couple of polishes for the 5.40.0 release.
1. Added README.md In the New
extensions
FolderFor better UX, the
extensions
folder will now also include a short README file, just so it's easier for users to know what the folder is and how to get started with creating a new extension.2. Deployment Logs Always Included In CI
With 5.40.0, deployment logs are automatically hidden. But, most probably, this should not be happening in CI environments. So, we ensured that the logs are always shown in CI environments.
3. Deployments -
allow-local-state-files
FlagWhen deploying into production environment, an error will be thrown if the user is using local state files. This is simply because it's not recommended. Still, if the uses wishes to ignore the error, they can do it by passing the
allow-local-state-files
flag.4. Extensions Scaffolds - Updating Dependencies In
package.json
When using the API / Admin scaffolds, respectively, the
apps/api/graphql/package.json
andapps/admin/package.json
are now updated with the new package that was created in the process. Previously this wasn't the case.5. Extensions Scaffolds - Added
--dependencies
ParameterWhen running the scaffold command in a non-interactive mode, users also now have the ability to pass the
--dependencies
flag in order to immediately add required dependencies in the new extension'spackage.json
. For example:Multiple dependencies can also be added, by separating them with a comma, for example:
6.
@webiny/pulumi-aws
-DEFAULT_PROD_ENV_NAMES
ConstantThroughout multiple files, we had the following line of code:
For easier maintenance, the
DEFAULT_PROD_ENV_NAMES
constant was introduced, and the above line has now been changed to:6.
@webiny/ui
- Removedimport "@rmwc/chip/styles";
ImportWe've noticed Webpack reporting a weird error upon building both Admin and Website apps:
After investigation, we've detected that it's because of the
import "@rmwc/chip/styles";
statement in thepackages/ui/src/Chips/Chips.tsx
file. Removing it resolved the issue, and, most importantly, did not cause any visual regressions with the component.7.
dynamoDbElasticsearchTable
No Longer Present In DDB-Only ProjectsThe
dynamoDbElasticsearchTable
property would always be included when deploying the API app, both in DDB-only and DDB+ES projects.Although it wasn't making any serious issues, when deploying a DDB-only project, a warning from Pulumi would be printed out.
With this minor fix, this is no longer the case.
How Has This Been Tested?
Manually.
Documentation
Changelog.