Abstracting reset.css Styles and Cleaning Up global.scss File
#4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we're abstracting the base
reset.cssstyles that are used within Admin/Website apps.Not only this is making it easier for users to grasp what's going on in the
extensions/theme, but also, by importing it ourselves, we can ensure that thereset.cssstyles are imported first, which is how these styles should be applied.We'll be revisiting the existing 5.40.0 project upgrade script so that these changes are taken into consideration.
How Has This Been Tested?
Manually.
Documentation
Changelog.