Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCC] Unreviewed, build fix for Debian Stable after 278486@main #28285

Merged
merged 1 commit into from
May 8, 2024
Merged

[GCC] Unreviewed, build fix for Debian Stable after 278486@main #28285

merged 1 commit into from
May 8, 2024

Conversation

dpino
Copy link
Contributor

@dpino dpino commented May 8, 2024 •
edited by webkit-early-warning-system
Loading

1ee00a2

[GCC] Unreviewed, build fix for Debian Stable after 278486@main
https://bugs.webkit.org/show_bug.cgi?id=273852

Internal compiler error: unexpected expression _static_cast<UnsignedType>('\"')_ of kind static_cast_expr.

Replace 'constexpr' for 'const'.

* Source/JavaScriptCore/runtime/JSONObject.cpp:
(JSC::FastStringifier<CharType>::append):

Canonical link: https://commits.webkit.org/278511@main

7f79a02

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@dpino dpino requested a review from a team as a code owner May 8, 2024 10:04
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 8, 2024 •
edited
Loading

EWS run on current version of this PR (hash 7f79a02)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@dpino dpino self-assigned this May 8, 2024
@dpino dpino added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2024
@dpino
[GCC] Unreviewed, build fix for Debian Stable after 278486@main
1ee00a2 
https://bugs.webkit.org/show_bug.cgi?id=273852

Internal compiler error: unexpected expression _static_cast<UnsignedType>('\"')_ of kind static_cast_expr.

Replace 'constexpr' for 'const'.

* Source/JavaScriptCore/runtime/JSONObject.cpp:
(JSC::FastStringifier<CharType>::append):

Canonical link: https://commits.webkit.org/278511@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix-build/debian-stable-after-278486@main branch from 7f79a02 to 1ee00a2 Compare May 8, 2024 16:02
@webkit-commit-queue
Copy link
Collaborator

Committed 278511@main (1ee00a2): https://commits.webkit.org/278511@main

Reviewed commits have been landed. Closing PR #28285 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1ee00a2 into WebKit:main May 8, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dpino dpino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpino @webkit-early-warning-system @webkit-commit-queue