Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrapEmoji is matching non-unicode characters #40

Closed
pauldps opened this issue May 3, 2024 · 0 comments · Fixed by #41
Closed

Bug: wrapEmoji is matching non-unicode characters #40

pauldps opened this issue May 3, 2024 · 0 comments · Fixed by #41

Comments

@pauldps
Copy link
Contributor

pauldps commented May 3, 2024 •
edited
Loading

Per the emoji spec, characters like plain numbers (0-9) and certain symbols (*, #, etc) are considered Emoji.
See: mathiasbynens/emoji-regex#33 (comment)

For the purposes of the wrapEmoji method, those characters should NOT be wrapped in HTML.

Only real unicode characters should be matched, which all real emoji are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrapEmoji should ignore all non-unicode webmuds/colors
1 participant
@pauldps