Skip to content

Commit

Permalink
Merge pull request #32 from nabinhait/3.0.0-hotfix
Browse files Browse the repository at this point in the history
3.0.0 hotfix
  • Loading branch information
nabinhait committed May 9, 2014
2 parents c76106c + 1d134b5 commit 8ff892b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ def get_items(self):
and so_item.parent in (%s) and ifnull(so_item.qty, 0) > ifnull(so_item.delivered_qty, 0)
and exists (select * from `tabItem` item where item.name=pi.item_code
and (ifnull(item.is_pro_applicable, 'No') = 'Yes'
or ifnull(item.is_sub_contracted_item, 'No') = 'Yes'))""" % \
(", ".join(["%s"] * len(so_list))), tuple(so_list), as_dict=1)
or ifnull(item.is_sub_contracted_item, 'No') = 'Yes')) %s""" % \
(", ".join(["%s"] * len(so_list)), item_condition), tuple(so_list), as_dict=1)

return items + packed_items

Expand Down
8 changes: 4 additions & 4 deletions stock/doctype/stock_reconciliation/stock_reconciliation.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ def validate_item(self, item_code, row_num):

# item should not be serialized
if item.has_serial_no == "Yes":
frappe.throw(_("Serialized item: {0} can not be managed using Stock Reconciliation, \
use Stock Entry instead").format(item_code))
raise webnotes.ValidationError, (_("Serialized item: {0} can not be managed \
using Stock Reconciliation, use Stock Entry instead").format(item_code))

# item managed batch-wise not allowed
if item.has_batch_no == "Yes":
frappe.throw(_("Item: {0} managed batch-wise, can not be reconciled using \
Stock Reconciliation, instead use Stock Entry").format(item_code))
raise webnotes.ValidationError, (_("Item: {0} managed batch-wise, can not be \
reconciled using Stock Reconciliation, instead use Stock Entry").format(item_code))

# docstatus should be < 2
validate_cancelled_item(item_code, item.docstatus, verbose=0)
Expand Down

0 comments on commit 8ff892b

Please sign in to comment.