Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caching #194

Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix: caching #194

merged 1 commit into from
Sep 14, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix:

  • weak cache for webpack@4
  • keep assets info for webpack@4
  • respect immutable info

Breaking Changes

No

Additional Info

We should refactor filename: Function, because it can create wrong filenames in some rare cases (if you return non immutable path - i.e. without [name] or [file] or [path]).

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #194 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   98.72%   98.75%   +0.03%     
==========================================
  Files           4        4              
  Lines         157      161       +4     
  Branches       46       47       +1     
==========================================
+ Hits          155      159       +4     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
src/Webpack4Cache.js 100.00% <100.00%> (ø)
src/Webpack5Cache.js 100.00% <100.00%> (ø)
src/index.js 98.41% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc01f0...e4b410d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant