Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: concurrency writing assets #484

Merged
merged 1 commit into from
May 16, 2020
Merged

fix: concurrency writing assets #484

merged 1 commit into from
May 16, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #482

Breaking Changes

No

Additional Info

Hard to test so I added comment

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #484 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   96.63%   96.72%   +0.09%     
==========================================
  Files           8        8              
  Lines         208      214       +6     
  Branches       57       57              
==========================================
+ Hits          201      207       +6     
  Misses          7        7              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/postProcessPattern.js 89.28% <100.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e62695...e0b735d. Read the comment docs.

@alexander-akait alexander-akait merged commit bfc712d into master May 16, 2020
@alexander-akait alexander-akait deleted the issue-482 branch May 16, 2020 13:29
apepper added a commit to Scrivito/scrivito_example_app_js that referenced this pull request Sep 17, 2020
If multiple patterns reference similar or identical files (e.g. "../public" and "../public/_headers") it is not well defined, which pattern will be executed - the first or the last? To avoid this confusion now "../public" is copied, but only "public/_headers" is transformed.

copy-webpack-plugin 6.0.1 most likely broke because of webpack-contrib/copy-webpack-plugin#484.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING in Conflict: Multiple assets emit different content to the same filename
1 participant