Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improving docs for minimizing options in webpack config #116

Conversation

dbailo1988
Copy link
Contributor

Please check if the PR fulfills these requirements

  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [x ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    I found myself problems doing the config for the minimizer so I hope it's more clear
    What is the current behavior? (You can also link to an open issue here)
    No behavior change

What is the new behavior?
No behavior change

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

Other information:

@jsf-clabot
Copy link

jsf-clabot commented Mar 9, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #116   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files           2       2           
  Lines          94      94           
  Branches       18      18           
======================================
  Hits           91      91           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c7b60...843c76e. Read the comment docs.

@dbailo1988 dbailo1988 force-pushed the IMPROVING_DOCS_FOR_MINIMIZING_OPTIONS branch from 39149f4 to 843c76e Compare March 9, 2017 13:05
@hemanth
Copy link
Contributor

hemanth commented Mar 9, 2017

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants