Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useable): add insertInto support (options.insertInto) #341

Merged

Conversation

jasonenglish
Copy link
Contributor

What kind of change does this PR introduce?

feature. adds support for insertInto with useable. fixes #327

Did you add tests for your changes?
Yes

If relevant, did you update the README?
I didn't, I figured this feature should be assumed to work with useable as well. I can add documentation to point it out though.

Summary

This feature is needed for injecting styles into the iframe with useable AFTER the page has loaded. Having the ability to call style.use() when the iframe is being setup is crucial. In this scenario we can't use the basic style-loader because specifying the insertInto option will attempt to look for the iframe when it doesn't exist yet.

Does this PR introduce a breaking change?

No

Other information
n/a

@jasonenglish jasonenglish changed the title Useable insert into feat(useable): support insertInto Aug 24, 2018
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #341 into master will decrease coverage by 1.33%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #341      +/-   ##
=========================================
- Coverage   98.43%   97.1%   -1.34%     
=========================================
  Files           4       4              
  Lines          64      69       +5     
  Branches       21      23       +2     
=========================================
+ Hits           63      67       +4     
- Misses          1       2       +1
Impacted Files Coverage Δ
useable.js 94.11% <80%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4217bd1...aa97e70. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait
Copy link
Member

/cc @michael-ciniawsky need release 👍

@michael-ciniawsky
Copy link
Member

Released in v0.23.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style-loader/useable: passing insertInto through options
3 participants