-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useable): add insertInto
support (options.insertInto
)
#341
feat(useable): add insertInto
support (options.insertInto
)
#341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=========================================
- Coverage 98.43% 97.1% -1.34%
=========================================
Files 4 4
Lines 64 69 +5
Branches 21 23 +2
=========================================
+ Hits 63 67 +4
- Misses 1 2 +1
Continue to review full report at Codecov.
|
insertInto
support (options.insertInto
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonenglish Thx
/cc @michael-ciniawsky need release 👍 |
Released in |
What kind of change does this PR introduce?
feature. adds support for insertInto with
useable
. fixes #327Did you add tests for your changes?
Yes
If relevant, did you update the README?
I didn't, I figured this feature should be assumed to work with
useable
as well. I can add documentation to point it out though.Summary
This feature is needed for injecting styles into the iframe with
useable
AFTER the page has loaded. Having the ability to callstyle.use()
when the iframe is being setup is crucial. In this scenario we can't use the basic style-loader because specifying the insertInto option will attempt to look for the iframe when it doesn't exist yet.Does this PR introduce a breaking change?
No
Other information
n/a