Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WorkerError): handle undefined error stacks #20

Merged
merged 1 commit into from
Feb 26, 2018
Merged

fix(WorkerError): handle undefined error stacks #20

merged 1 commit into from
Feb 26, 2018

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Feb 25, 2018

Issues

Notable Changes

Before this change, an error reported without a stack would crash the process:
image

After this change, the error is properly reported:
image

@jsf-clabot
Copy link

jsf-clabot commented Feb 25, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 25, 2018

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #20   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           7     7           
  Lines         372   372           
  Branches       65    66    +1     
====================================
+ Misses        326   325    -1     
- Partials       46    47    +1
Impacted Files Coverage Δ
src/WorkerError.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ec236...121cec8. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title fix(WorkerError): handle null error stacks fix(WorkerError): handle undefined error stacks Feb 25, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfederm Thx

@michael-ciniawsky
Copy link
Member

Released in v1.1.5 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 1.1.6 milestone Feb 26, 2018
@dfederm dfederm deleted the handle-null-err-stack branch February 27, 2018 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants