-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide tooltip when hovering over the attribution group and between top level groups. #413
Conversation
…-level groups. (cherry picked from commit 93e98aa)
Thanks! Would you be able to showcase the difference in behavior with a small screencap or something? It would make it easier to understand how this behavior has changed now |
Before: tooltips-before.mp4After: tooltip-after.mp4 |
Nice, thank you! Looks great! Would you be able to write a small note on the changelog about this? |
event.preventDefault(); | ||
if (props.onMouseLeave) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this conditional? Is there a place in the code where props.onMouseLeave
would not be specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the condition analogous to the props.onGroupHover
check below, which is also there but probably not required:
if (props.onGroupHover) {
props.onGroupHover.call(component, event);
}
I can remove the props.onMouseLeave
condition, not a problem.
Thanks! |
No description provided.