Fix webpack 4 warning #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, this looks good to me! Were you able to check that this fixes ai/size-limit#42 warning being displayed, and that things still work with webpack 4? |
|
@valscion I still have a warning because 2 other plugins use old API :(. It is the long way :D. But I tested and everything works in Webpack 4. |
|
@valscion Travis CI is broken because of timeout :) |
|
I sent PR to |
|
Super awesome, thank you! This looks good to me 👍. I added a changelog entry and will soon merge this once tests pass and then release a new patch version. |
|
Released in v2.10.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154 according to @sokra suggestion