Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Webpack to v4. #42

Closed
wants to merge 2 commits into from
Closed

Conversation

jaydenseric
Copy link
Contributor

Fixes #41:

  • Updated Webpack dependency to v4.0.0-beta.2.
  • Updated Webpack related dependencies for the Yarn lock file.
  • In the changelog fixed capitalization of “Webpack” everywhere and ran Prettier.

- Updated Webpack dependency to v4.0.0-beta.2.
- Updated Webpack related dependencies for the Yarn lock file.
- In the changelog fixed capitalization of “Webpack” everywhere and ran Prettier.
@jaydenseric
Copy link
Contributor Author

jaydenseric commented Feb 21, 2018

Tested it using npm link, and it seems ok:

screen shot 2018-02-21 at 1 08 47 pm

The warning is harmless, some packages are waiting for a stable v4 before adopting the new API and Webpack will still support the old for a while.

I looked into all the Webpack related dependencies and I could not find anything that would break moving to v4.

@ai
Copy link
Owner

ai commented Feb 21, 2018

@jaydenseric do you have this warning without --why?

@jaydenseric
Copy link
Contributor Author

Yes.

@ai
Copy link
Owner

ai commented Feb 21, 2018

Could you please revert ChangeLog changes? ;) If you want to change format, it should be in the different PR.

@jaydenseric
Copy link
Contributor Author

The changelog formatting matches the same way you have the readme formatted; new lines under headings.

@ai
Copy link
Owner

ai commented Feb 21, 2018

  1. The warning should be from WebpackBundleAnalyzer. It is an only plugin added on --why.
  2. In README.md I also have double new lines at the end of a section. I am not sure that we should copy this format to ChangeLog. Format purposes are different.

@ai
Copy link
Owner

ai commented Feb 21, 2018

Seems like you also need to fix tests, Webpack 4 changes sizes and WEBPACK_EMPTY_PROJECT

@jaydenseric
Copy link
Contributor Author

Feel free to add commits to get this PR across the line, I don't have this project open anymore and am too busy ATM to work out the tests and things to see it through 🙂

@ai
Copy link
Owner

ai commented Feb 21, 2018

@jaydenseric don’t worry. I will finish it over the weekend. Can I only ask you to revert ChangeLog changes, because if I accept this PR (to fix tests), git history will be tricky?

@ai
Copy link
Owner

ai commented Feb 21, 2018

I created issue about depreacted warning:

webpack-contrib/webpack-bundle-analyzer#154

Also I should think on weekends about using Webpack’s mode instead of manually set UglifyJS.

@ai
Copy link
Owner

ai commented Feb 23, 2018

I made a PR to Webpack Bundle Analyzer. Since warning is showing in any Size Limit mode, I need to wait for this PR (or Size Limit tests will fail).

@ai
Copy link
Owner

ai commented Feb 23, 2018

PR to uglify-webpack-plugin was sent too webpack-contrib/uglifyjs-webpack-plugin#238

@ai
Copy link
Owner

ai commented Feb 23, 2018

PR to compression-webpack-plugin was sent too webpack-contrib/compression-webpack-plugin#100

@ai
Copy link
Owner

ai commented Feb 23, 2018

All PRs were accepted. I manually took changes from this commit aca11bf

@ai ai closed this Feb 23, 2018
@ai
Copy link
Owner

ai commented Feb 23, 2018

Released in 0.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update webpack to v4 for .mjs support
2 participants