This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix(index): handle protocol URL's correctly (options.publicPath)
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
force-pushed
the
fix/publicPath
branch
from
d4ed783
to
21dbe06
Compare
michael-ciniawsky
changed the title
options.publicPath)
michael-ciniawsky
force-pushed
the
fix/publicPath
branch
from
21dbe06
to
5b81618
Compare
alexander-akait
suggested changes
Feb 21, 2018
src/index.js
Outdated
| let outputPath = ( | ||
| typeof options.outputPath === 'function' ? options.outputPath(url) : path.join(options.outputPath || '', url) | ||
| ); | ||
| let outputPath = null; |
There was a problem hiding this comment.
let outputPath = url; and remove else
src/index.js
Outdated
| @@ -40,11 +54,16 @@ export default function loader(content) { | |||
|
|
|||
| let publicPath = null; | |||
There was a problem hiding this comment.
publicPath = `__webpack_public_path__ + ${JSON.stringify(outputPath)}`; and remove else
michael-ciniawsky
force-pushed
the
fix/publicPath
branch
from
5b81618
to
65642e1
Compare
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 2 (urgent)
severity: 2 (regression)
status: Pending
labels
This was referenced Feb 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IssuesNotable ChangesSince
publicPathcan be a full URL (which can contain protocols), usingpath.join()to concat file paths isn't sufficient here