fix: Add null check to removeStyleElement
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-ciniawsky
changed the title
removeStyleElement
|
@brandondurham Please sign the CLA, in case the bot bugs close and reopen the PR to trigger it again |
joshwiens
approved these changes
May 30, 2017
joshwiens
changed the title
removeStyleElementremoveStyleElement
alexander-akait
requested changes
May 30, 2017
lib/addStyles.js
Outdated
| style.parentNode.removeChild(style); | ||
|
|
||
| var idx = stylesInsertedAtTop.indexOf(style); | ||
|
|
||
| if(idx >= 0) { | ||
| if (idx >= 0) { |
There was a problem hiding this comment.
Don't change not related lines to PR
There was a problem hiding this comment.
Sorry about that. Subconscious flick of the wrist. Should be good to go.
alexander-akait
approved these changes
May 30, 2017
bebraw
approved these changes
May 30, 2017
|
@brandondurham Thx |
michael-ciniawsky
changed the title
removeStyleElementnull check to removeStyleElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Private function… no tests.
If relevant, did you update the README?
Not relevant.
Summary
style-loader was choking on the CSS Modules
composesfeature and throwing a fatal error. Adding a check to theremoveStyleElementfunction inlib/addStyles.jsseems to solve the problem.Does this PR introduce a breaking change?
No.
Closes #182