tests: added tests for config #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Aug 25, 2019
|
@anikethsaha Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
ematipico
suggested changes
Aug 26, 2019
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
ematipico
approved these changes
Aug 27, 2019
evenstensberg
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Test
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Added tests for config #1012
Does this PR introduce a breaking change?
No
Other information
More configs tests (advance) are coming soon. Just want to check if this way is fine by the team