tests(webpack-cli): correct descriptions for no-mode test cases #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
previously approved these changes
Mar 12, 2020
anshumanv
previously approved these changes
Mar 12, 2020
jamesgeorge007
previously approved these changes
Mar 13, 2020
wizardofhogwarts
previously approved these changes
Mar 13, 2020
snitin315
dismissed stale reviews from wizardofhogwarts, jamesgeorge007, anshumanv, and rishabh3112
via
f8cb201
alexander-akait
previously approved these changes
Mar 16, 2020
anshumanv
previously approved these changes
Mar 16, 2020
snitin315
dismissed stale reviews from anshumanv and alexander-akait
via
476b5e9
snitin315
force-pushed
the
tests/no-mode
branch
from
f8cb201
to
476b5e9
Compare
I separated the different corrections to avoid confusion. |
snitin315
requested review from
anshumanv,
jamesgeorge007,
alexander-akait and
rishabh3112
alexander-akait
previously approved these changes
Mar 18, 2020
snitin315
force-pushed
the
tests/no-mode
branch
from
6748689
to
f4a82db
Compare
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
|
@anshumanv Done 💯 |
alexander-akait
approved these changes
Mar 18, 2020
jamesgeorge007
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Minor fix.
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Summary
Self Explanatory
Does this PR introduce a breaking change?
No
Other information