Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: general corrections and improvements #1354

Merged
merged 1 commit into from
Mar 20, 2020
Merged

docs: general corrections and improvements #1354

merged 1 commit into from
Mar 20, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 20, 2020 •
edited

What kind of change does this PR introduce?

general corrections and improvements in documentation.

Did you add tests for your changes?

YES.

If relevant, did you update the documentation?

Yes

Summary

Does this PR introduce a breaking change?

No
Other information

@snitin315 snitin315 requested a review from a team as a code owner March 20, 2020 08:27
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

anshumanv
anshumanv requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such small improvements can be a part of single PR - #1351

himanshu010
himanshu010 suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@himanshu010 himanshu010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't open different pr for such small change, merge it with #1351

@snitin315
Copy link
Member Author

Such small improvements can be a part of single PR - #1351

Once I was told not to mix various corrections in one PR. (comment)

Let's keep this one open for some time I will make all docs related changes in this one at once.

@anshumanv
Copy link
Member

Let's keep this one open for some time I will make all docs related changes in this one at once.

Sounds good!

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@himanshu010 Please review the new changes.

@snitin315 snitin315 changed the title docs(readme): use correct pronoun docs: general corrections and improvements Mar 20, 2020
anshumanv
anshumanv approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rishabh3112 rishabh3112 merged commit 53feed8 into webpack:next Mar 20, 2020
@rishabh3112
Copy link
Member

Thanks!

@snitin315 snitin315 mentioned this pull request Mar 20, 2020
Merged
@snitin315 snitin315 deleted the docs/readme branch March 21, 2020 05:35
@anshumanv anshumanv mentioned this pull request Apr 2, 2020
Closed
@anshumanv anshumanv mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu010 himanshu010 himanshu010 requested changes

@alexander-akait alexander-akait alexander-akait approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@anshumanv anshumanv anshumanv approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@snitin315 @webpack-bot @anshumanv @rishabh3112 @alexander-akait @himanshu010