-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove stale code and improve logic #1351
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest keeping this open for a while, go through the code and remove all stale code and logic improvement at once.
@anshumanv There are two more warnings in I'm not sure what should be used instead of |
Rest all code looks good to me. |
add09d7
to
12ef69a
Compare
@snitin315 it should be Let me know if that works. |
12ef69a
to
1ebda35
Compare
It worked thanks. |
/cc @webpack/cli-team need review |
Will take a look locally in a while. |
3208ab5
to
5825594
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
5825594
to
8b24d92
Compare
Thanks |
What kind of change does this PR introduce?
Refactoring.
Removed the stale imports, unused code & improved logic.
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
The motivation for this change -
Does this PR introduce a breaking change?
NO
Other information