Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stale code and improve logic #1351

Merged
merged 5 commits into from
Mar 22, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 18, 2020

What kind of change does this PR introduce?

Refactoring.
Removed the stale imports, unused code & improved logic.

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
The motivation for this change -

Screenshot from 2020-03-18 17-34-51

Does this PR introduce a breaking change?

NO
Other information

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest keeping this open for a while, go through the code and remove all stale code and logic improvement at once.

@snitin315
Copy link
Member Author

Would suggest keeping this open for a while, go through the code and remove all stale code and logic improvement at once.

@anshumanv There are two more warnings in /package-utils/__tests__ regarding the use of type any -

Screenshot from 2020-03-18 17-49-34

I'm not sure what should be used instead of any.

@snitin315
Copy link
Member Author

Rest all code looks good to me.

@anshumanv
Copy link
Member

@anshumanv There are two more warnings in /package-utils/tests regarding the use of type any -

@snitin315 it should be jest.Mock 👍

Let me know if that works.

@snitin315
Copy link
Member Author

Let me know if that works.

It worked thanks.

@alexander-akait
Copy link
Member

/cc @webpack/cli-team need review

@anshumanv
Copy link
Member

Will take a look locally in a while.

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

@snitin315 snitin315 changed the title chore(info): remove stale code and improve logic chore: remove stale code and improve logic Mar 22, 2020
jamesgeorge007
jamesgeorge007 previously approved these changes Mar 22, 2020
@jamesgeorge007 jamesgeorge007 merged commit 1ca30fa into webpack:next Mar 22, 2020
@jamesgeorge007
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants