Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix jsdoc comment for a test util function run #1377

Merged
merged 1 commit into from
Mar 26, 2020
Merged

docs: Fix jsdoc comment for a test util function run #1377

merged 1 commit into from
Mar 26, 2020

Conversation

kabirbaidhya
Copy link
Contributor

What kind of change does this PR introduce?

A trivial jsdoc fix. Fixes docblock for a test util function run.
(chore)

@kabirbaidhya kabirbaidhya requested a review from a team as a code owner March 25, 2020 20:08
@jsf-clabot
Copy link

jsf-clabot commented Mar 25, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Mar 25, 2020

There were the following issues with this Pull Request

  • Commit: dc7dfc5
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@anshumanv
Copy link
Member

Hi! Thanks for contributions.

Please sign the CLA and commit using npm run commit to commit as per commit guidelines. 😄

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@kabirbaidhya
docs: ✏️ Fix jsdoc comment for run util function
fabfd05 
Fix doc block text for the `run` test util function and minor code style
tweak.
@kabirbaidhya kabirbaidhya changed the title Fix jsdoc description for a test util function run docs: Fix jsdoc comment for a test util function run Mar 25, 2020
@rishabh3112 rishabh3112 merged commit ab8e59f into webpack:next Mar 26, 2020
@rishabh3112
Copy link
Member

Thanks!

@kabirbaidhya kabirbaidhya deleted the patch-1 branch March 26, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kabirbaidhya @jsf-clabot @anshumanv @webpack-bot @rishabh3112 @jamesgeorge007