Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove --dev and --prod flags #1693

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
removed related tests
If relevant, did you update the documentation?
yes
Summary
remove --dev and --prod as discussed here #1688 (comment)

Does this PR introduce a breaking change?
No, these options were added in beta.

Other information

Not a big deal but even if I understand the point of having clean and concise --dev and --prod options, I think the --mode= option better matches the way it works in the configuration file and is more straightforward when you already know configuration file. Just my 2 cents, but I'm not sure a breaking change in this area is really useful?

from feedback

@snitin315 snitin315 requested a review from a team as a code owner July 19, 2020 11:39
@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@snitin315 snitin315 merged commit 23a248a into next Jul 21, 2020
@snitin315 snitin315 deleted the refactor/dev-and-prod branch July 21, 2020 10:43
silasary added a commit to PennyDreadfulMTG/Penny-Dreadful-Tools that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants