Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: loader's tests for errors and warnings #1736

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
test

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1581

Does this PR introduce a breaking change?
No

Other information

@snitin315 snitin315 requested a review from a team as a code owner August 6, 2020 11:00
@alexander-akait
Copy link
Member

deprecations from ts-loader?

@snitin315
Copy link
Member Author

Yes, can we test on stdout only?

@alexander-akait
Copy link
Member

Yes, let comment stderr (with comment on issue), open an issue in ts-loader and merge it

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need improve test

test/loader/error-test/loader-error.test.js Show resolved Hide resolved
@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it was fixed after removing execa

@snitin315
Copy link
Member Author

still same 😞

@alexander-akait
Copy link
Member

@snitin315 We need to solve it before release, there are two possible problems:

  • our test utils is not respect exit code
  • something wrong inside webpack-cli logic in try/catch

@alexander-akait
Copy link
Member

/cc @snitin315 Can we focus on it, because it is high priority for new release, we don't want break linter-loaders and other stuff what potential change exit code

@snitin315
Copy link
Member Author

Yes, I'm looking into it.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note

test/loader/warning-test/src/main.js Show resolved Hide resolved
@snitin315 snitin315 changed the title tests: loader's error regression test for #1581 tests: loader's tests for errors and warnings Aug 19, 2020
@alexander-akait
Copy link
Member

/cc @webpack/cli-team we need fix it before release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-cli v4-beta.8 ignoring loader's error.
6 participants