Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env preset #197

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Use env preset #197

merged 3 commits into from
Dec 12, 2017

Conversation

itsMapleLeaf
Copy link
Contributor

Closes #196

@jsf-clabot
Copy link

jsf-clabot commented Dec 12, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@evenstensberg
Copy link
Member

Hey @kingdaro , awesome work! Could you install the plugin and remove the babel-preset-es2015 from package.json ?

1. npm uninstall babel-preset-es2015
2. npm install --save babel-preset-env

@itsMapleLeaf
Copy link
Contributor Author

Sure thing, also updated the relevant docs and configuration as well

@evenstensberg
Copy link
Member

Could you do npm install now? The package-lock.json should be updated if you followed the steps 👍

evenstensberg
evenstensberg approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evenstensberg evenstensberg merged commit 9a72beb into webpack:feature/add Dec 12, 2017
@itsMapleLeaf itsMapleLeaf deleted the feature/add branch December 12, 2017 23:53
@itsMapleLeaf itsMapleLeaf restored the feature/add branch December 12, 2017 23:57
@evenstensberg evenstensberg mentioned this pull request Dec 17, 2017
Merged
@enterstudio enterstudio mentioned this pull request Nov 5, 2022
Open
@dhruvdutt dhruvdutt mentioned this pull request Nov 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itsMapleLeaf @jsf-clabot @evenstensberg