fix: allow falsy values for "port" option #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack-dev-server@3 allows using `null` or `0` to automatically use a free port.
|
|
|
Please accept CLA, also I want to note - please prefer to use |
|
Thank you @alexander-akait. I will make a note of that for when we upgrade to v4. |
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 31 31
Lines 1684 1685 +1
Branches 483 483
=======================================
+ Hits 1602 1603 +1
Misses 82 82
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Sep 21, 2021
anshumanv
approved these changes
Sep 21, 2021
anshumanv
pushed a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
Open to suggestions for testing this.
If relevant, did you update the documentation?
N/A
Summary
This fixes a regression that we noticed when updating to
webpack-cli@4.7.2. We are still onwebpack-dev-server@3.11.2which allows usingnullor0to automatically use a free port. In our case we are settingport: 0and it was causing this error:If
webpack-clistill supportswebpack-dev-server@3.11.2it seems like it shouldn't prevent passingnullor0as an option toport. Our current workaround is using the string'0', which is not falsy.Does this PR introduce a breaking change?
No
Other information