enh(Add open collective prompt) #755

misterdev · 2019-02-06T15:29:03Z

I'm adding a console message to ask the users for donations, following how it is implemented in opencollective-cli

OSX

Windows

At the moment this is printed by the postinstall script. It can be improved by printing the banner sometimes during the cli usage as suggested in @evenstensberg example

LANG=C DAY=$(date +"%a")

if [ "$DAY" == "Mon" ];
then
    printDonationHeader

I think we can print it during cli usage with probability 1/50, I will work on this.

Did you add tests for your changes?
No. Should I?

If relevant, did you update the documentation?
It's not relevant

Summary
Adds a "support us on open collective" closing #752
Closes #752

Does this PR introduce a breaking change?
No

package.json

bin/opencollective.js

ematipico

Just left few comments and enhancements! Overall looks good to me!
Should we show the banner only once a week though? Better to not be too invasive

misterdev · 2019-02-06T21:57:06Z

Thanks @ematipico for your feedback, I've included those changes.

I've improved the formatting of the output, now it's prettier and well centered:

Also, this is showed once a week, I do this by saving the timestamp of the last print in a file called ./.lastocprint, so every time we run webpack-cli it have to read from the file system. Is this a good solution?

I think this is complete, feedback are welcome 👍

misterdev · 2019-03-05T15:17:50Z

@ematipico you can review this if you want

bin/opencollective.js

webpack-bot · 2019-03-11T15:23:30Z

@misterdev Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

ghost · 2019-03-11T15:40:08Z

There were the following issues with this Pull Request

Commit: f66368f
- ✖ message may not be empty
- ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

webpack-bot · 2019-03-11T17:51:58Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

bin/opencollective.js

misterdev · 2019-03-13T20:08:10Z

The prompt shows only on Monday if the last time it has been shown was more than 6 days earlier.
I've used Stats.atime as suggested by @evenstensberg to determine the last time the file (opencollective.js) has been executed. On windows seems that the atime is not updated when opencollective.js is executed, so I've added an instruction that sets it.

evenstensberg · 2019-03-15T18:36:17Z

bin/cli.js

@@ -473,6 +473,22 @@ For more information, see https://webpack.js.org/api/cli/.`);
 					const statsString = stats.toString(outputOptions);
 					const delimiter = outputOptions.buildDelimiter ? `${outputOptions.buildDelimiter}\n` : "";
 					if (statsString) stdout.write(`${statsString}\n${delimiter}`);
+
+
+					const now = new Date();


add comment here , maybe abstract to a local function. Needs more comments and explaination.

I've added this comment on top:

/** * Show a hint to donate to our Opencollective * once a week, only on Monday */

evenstensberg · 2019-03-15T18:37:59Z

bin/cli.js

+						const { statSync, utimesSync } = require("fs");
+						const lastPrint = statSync(openCollectivePath).atime;
+						const lastPrintTS = new Date(lastPrint).getTime();
+						if (now.getTime() - lastPrintTS > SIX_DAYS) {


abstract to expression or function that has the naming installedLaterThanSixDays or similar.

I've abstracted to a variable:

const timeSinceLastPrint = now.getTime() - lastPrintTS; if (timeSinceLastPrint > SIX_DAYS) {

Thanks for your comments, let me know if I can make any other improvements 👍

evenstensberg

lgtm

sbrunner · 2019-04-29T10:52:09Z

bin/cli.js

+						if (timeSinceLastPrint > SIX_DAYS) {
+							require(openCollectivePath);
+							// On windows we need to manually update the atime
+							utimesSync(openCollectivePath, now, now);


This line breaks the build on Linux when we install Webpack globally :-(

:( Could you please open an issue with some details about the error?

=> #870 :-)

See: webpack/webpack-cli#755 Commit in a patch version :-(

webpack-bot added the PR: unreviewed label Feb 6, 2019

misterdev changed the title ~~[WIP] feat(add opencollective msg): add script in package.json & nice prompt~~ [WIP] feat(Add open collective prompt) Feb 6, 2019