Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scaffolding): improved structure, formatting, typos #773

Merged
merged 11 commits into from
Mar 15, 2019

Conversation

misterdev
Copy link
Contributor

I've updated the SCAFFOLDING documentation to be more clean and structured.

Here you can find it visualized by github.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix and this is good!

SCAFFOLDING.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Mar 9, 2019

There were the following issues with this Pull Request

  • Commit: f66368f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Mar 9, 2019

There were the following issues with this Pull Request

  • Commit: f66368f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@misterdev misterdev force-pushed the misterdev-format-scaffold branch 2 times, most recently from 19c3d23 to d47eea0 Compare March 9, 2019 17:32
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR.

SCAFFOLDING.md Outdated Show resolved Hide resolved
SCAFFOLDING.md Show resolved Hide resolved
SCAFFOLDING.md Outdated Show resolved Hide resolved
SCAFFOLDING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has your branch have the latest from develop? I don't get all the errors in the CI

@misterdev
Copy link
Contributor Author

@ematipico seems the CI is failing on master

https://travis-ci.org/webpack/webpack-cli/builds/504104354

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Don't remove sentences here, you can revise or fix grammar mistakes but it seems like most of this is making the guide redundant and confusing

SCAFFOLDING.md Outdated Show resolved Hide resolved
SCAFFOLDING.md Outdated Show resolved Hide resolved
SCAFFOLDING.md Show resolved Hide resolved
SCAFFOLDING.md Outdated Show resolved Hide resolved
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
One more suggestion :)

SCAFFOLDING.md Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@misterdev Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do this everywhere in the file :)

SCAFFOLDING.md Outdated Show resolved Hide resolved
SCAFFOLDING.md Outdated Show resolved Hide resolved
@evenstensberg evenstensberg merged commit 398e39a into webpack:master Mar 15, 2019
@misterdev misterdev deleted the misterdev-format-scaffold branch March 19, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants