Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Webpack-CLI v4 Foundation #988

Closed
wants to merge 19 commits into from
Closed

Conversation

evenstensberg
Copy link
Member

What kind of change does this PR introduce?
Merges the work on v4 to master branch.

Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
This PR will make it easier for outside collaborators to help out developing the new cli version. It's a lot of work left and some help on getting this ready would be great. After this has been merged, we can close outdated issues and triage new ones related to the master branch that has been updated.

Even though you could argue that keeping your LTS version on master intact, I do not agree in this instance, because the next branch is a bit mysterious right now, as well as there's no real contributions from multiple collaborators. This will make it easier to change that.

The core work which introduces the kind of structure we want is there. We need to adjust now to make this production ready, which means that we'll need to simplify some logic in the code, write some comments in the code and make the src easier to work with.

Does this PR introduce a breaking change?
Not yet

Other information
N/A

feat: v4

chore: structure

chore: wip

chore: wip

cli: map groups with args

chore: wip on groups

chore:[WIP] update minimal optionsSchema

chore: remove unneeded code

chore: removed some double loops for perf

chore: [WIP] schema format simplified

chore: wip on typechecking

chore: remove old files

chore: remove unneeded props

chore: revise prop file

chore: trim down props

chore: wip on schema

chore: wip on validation

chore: replace yargs

chore: work on validation

feat: processing logic

chore: revise schema

feat: new options

chore: add cmd-line-usage

chore: simplify

chore: wip on validation logic

chore: wip on validation

chore: wip on logic

feat: fix installation

chore: fix edge case

chore: use ternary on exit

feat: add webpack-logger

chore: wip on abstraction layer

chore: wip on flags

feat: better abstraction level

feat: proccessing logic

feat: memfs infra

chore: setup initial compilation

feat: add remaining args

misc: move around and rename flag file

chore: fix linting

chore: remove redundant file

chore: revise return statement

chore: remove console.log

Fixed eslint errors

Merge fixeds

feat: wip on config resolving

chore: wip on config

chore: add extend option

chore: wip on inital proto

chore: wip

chore: better iteration

chore: fine tuning

chore: wip

chore: re-add deps

chore: update deps

chore: rebase

chore: rebase

chore: rebase

chore: rebse

chore: rebase

chore: revise

chore: wip

chore: wip

ench: remove some options

chore: revise some options

chore: rename options

chore: wip

chore: wip

chore: add analyze to command

chore: revise desc

chore: wip

chore: remove redundant file

chore: wip on infra

chore: add conventional config lookup

cHore: wip

chore: wip

chore: wip

chore: wip

chore: rebase

chore: remove old folder

chore: rebase

chore: add lerna

chore: lerna it

chore: lernaa

docs: fixed documentation
@evenstensberg
Copy link
Member Author

Squash merge fyi, I'm not good at commit messages

@ematipico ematipico changed the title Feat: Webpack-CLI v4 Foundation BREAKING CHANGE: Webpack-CLI v4 Foundation Jul 8, 2019
@webpack-bot

This comment has been minimized.

@evenstensberg
Copy link
Member Author

After discussion with @ematipico and the rest of the team, we're gonna make the next default branch instead. Makes it easier for contributors to help develop and we do not use that much time reviewing PRs on the master branch (which takes away time from the new version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants