Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling index serving #1254

Closed
wants to merge 1 commit into from

Conversation

ForbesLindesay
Copy link

What kind of change does this PR introduce?

This is a small feature

Did you add or update the examples/?

no

Summary

If you are doing server side rendering, by sending all HTML requests to a proxy, and your webpack config generates an index.html file, that file will get served instead of your server-side-rendered content for the root of the domain. Passing an index value of false to webpack-dev-middleware prevents it from serving the index file, but it violates the current schema for options passed into webpack dev server.

Does this PR introduce a breaking change?

No, this merely allows an extra value to be passed in for an existing option.

Other information

You can work around this issue by passing in '' which is close enough to false to trigger the desired behaviour in webpack-dev-middleware, but also a string so it passes validation.

@jsf-clabot
Copy link

jsf-clabot commented Jan 3, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@shellscape
Copy link
Contributor

Thanks for the PR and congrats on your first submission to the project. Unfortunately we're not accepting any new features for the foreseeable future. We do appreciate it though!

@shellscape shellscape closed this Jan 9, 2018
@ForbesLindesay
Copy link
Author

I'd appreciate an individual response as to why you think this library is better without the attached change. It's difficult not to be offended by a generic response stating that you do not accept any new features, however small, simple or reasonable they are.

What is your suggestion for how this should be handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants