Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up search for the site #184

Closed
bebraw opened this issue Sep 22, 2016 · 19 comments
Closed

Set up search for the site #184

bebraw opened this issue Sep 22, 2016 · 19 comments

Comments

@bebraw
Copy link
Contributor

bebraw commented Sep 22, 2016

Algolia would work.

I'm opening this based on Twitter discussion.

@joshed-io
Copy link
Contributor

Great! Per the comment on Twitter, what thoughts did you have in mind for the design?

@bebraw
Copy link
Contributor Author

bebraw commented Sep 22, 2016

@dzello Mostly fine. The structure of the site is completely different now, though, so that might affect your side. The search control needs a good location. Maybe header? See http://webpack.js.org/ .

@joshed-io
Copy link
Contributor

Ok, good to know. If the new content structure is different that's ok, I will have to make some config changes but should be mostly painless. From clicking around on the new site it looks like some content isn't there yet. Should I hold off on trying to index it until there's more there?

The header is good for location, that's what we did on the React docs.

@bebraw
Copy link
Contributor Author

bebraw commented Sep 22, 2016

You can index it, but it's correct it won't yield a lot of results yet. But then, I assume you index it regularly so going with the new structure can't hurt.

@joshed-io
Copy link
Contributor

Right, once the config is live we re-index every 24 hours to pick up any changes. I will play with indexing the new site and see where I get. Any ideas for timeline on having all the new content up?

@bebraw
Copy link
Contributor Author

bebraw commented Sep 22, 2016

All content - months.

Minimum will take less. There's a target for that.

@joshed-io
Copy link
Contributor

Sounds good, no problem to get new indexing configuration done by then.

In the meantime, for the sake of asking, do you think it's worth deploying search for the existing docs since the PR is ready to go? I don't want to make extra work but one upside of deploying for the existing docs is that we'll have more data to improve search for V2.

@bebraw
Copy link
Contributor Author

bebraw commented Sep 22, 2016

@dzello Yeah, getting the search on the old site could be worthwhile. Just poked about that so we get a decision made.

@sokra
Copy link
Member

sokra commented Sep 24, 2016

google custom search can work too...

@joshed-io
Copy link
Contributor

The Google custom search UX isn't great for docs. No autocomplete, irrelevant suggested searches, clumsy modal dialog for displaying results. Also there's ads and you have to pay to remove them.

@SpaceK33z
Copy link
Member

I'm +1 for Algolia. Laravel also uses this on their docs, and having used those docs extensively, I can say that it's very nice to work with. I especially like the autocomplete which allows me to quickly navigate. If it's free, I don't see any disadvantage.

@jhnns
Copy link
Member

jhnns commented Oct 12, 2016

If a documentation site uses google custom search, I'm instantly annoyed ^^. I don't like the results.

@SpaceK33z
Copy link
Member

@dzello, are you still interested in adding search for this repo? We'd love it if you could do a PR :).

@joshed-io
Copy link
Contributor

@SpaceK33z yes, I will start getting that together :)

@bebraw
Copy link
Contributor Author

bebraw commented Oct 15, 2016

@dzello Could you provide us the api key + webpack id for Algolia API? It should be straight-forward to set up after that once you have indexing going (just did integration of my own).

@joshed-io
Copy link
Contributor

@bebraw Yes, will provide once I have indexing going. In the meantime for development or testing you could use the DocSearch index for the existing site. App Id: bh4d9od16a, API Key: 93950c6eda05068a6f0649e4a7f7546e, Index name: webpack.

@skipjack
Copy link
Collaborator

@bebraw @dzello Started working on a branch to add the interface bits (e.g. a togglable input in the Navigation bar) for you to hook into, haven't it pushed it yet by I should be able to open a PR for that sometime tonight or tomorrow.

@joshed-io
Copy link
Contributor

Good to know @skipjack, thanks!

@SpaceK33z
Copy link
Member

Fixed with PR #284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants