-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to webpack 4 #2389
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9e2016a
Update references to webpack 4
afontcu 5985607
Remove dates from logs
afontcu f866de5
Merge branch 'master' into patch-5
montogeek 6b98ba9
Merge branch 'master' into patch-5
montogeek c9f2209
Merge branch 'master' into patch-5
afontcu 5c5d44b
Merge branch 'master' into patch-5
montogeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,15 +6,8 @@ contributors: | |
- jouni-kantola | ||
- skipjack | ||
- dannycjones | ||
- afontcu | ||
related: | ||
- title: Predictable Long Term Caching | ||
url: https://medium.com/webpack/predictable-long-term-caching-with-webpack-d3eee1d3fa31 | ||
- title: Webpack & Caching | ||
url: https://gist.github.com/sokra/ff1b0290282bfa2c037bdb6dcca1a7aa | ||
- title: Advanced Webpack Presentation | ||
url: https://presentations.survivejs.com/advanced-webpack/ | ||
- title: Issue 1315 | ||
url: https://github.com/webpack/webpack/issues/1315 | ||
- title: Issue 652 | ||
url: https://github.com/webpack/webpack.js.org/issues/652 | ||
--- | ||
|
@@ -149,7 +142,7 @@ Time: 3027ms | |
Asset Size Chunks Chunk Names | ||
runtime.cc17ae2a94ec771e9221.js 1.42 KiB 0 [emitted] runtime | ||
main.e81de2cf758ada72f306.js 69.5 KiB 1 [emitted] main | ||
index.html 275 bytes [emitted] | ||
index.html 275 bytes [emitted] | ||
[1] (webpack)/buildin/module.js 497 bytes {1} [built] | ||
[2] (webpack)/buildin/global.js 489 bytes {1} [built] | ||
[3] ./src/index.js 309 bytes {1} [built] | ||
|
@@ -204,7 +197,7 @@ Time: 475ms | |
runtime.cc17ae2a94ec771e9221.js 1.42 KiB 0 [emitted] runtime | ||
vendors.a42c3ca0d742766d7a28.js 69.4 KiB 1 [emitted] vendors | ||
main.abf44fedb7d11d4312d7.js 240 bytes 2 [emitted] main | ||
index.html 353 bytes [emitted] | ||
index.html 353 bytes [emitted] | ||
[1] (webpack)/buildin/module.js 497 bytes {1} [built] | ||
[2] (webpack)/buildin/global.js 489 bytes {1} [built] | ||
[3] ./src/index.js 309 bytes {2} [built] | ||
|
@@ -293,49 +286,58 @@ __webpack.config.js__ | |
const HtmlWebpackPlugin = require('html-webpack-plugin'); | ||
|
||
module.exports = { | ||
entry: { | ||
main: './src/index.js', | ||
vendor: [ | ||
'lodash' | ||
] | ||
}, | ||
entry: './src/index.js', | ||
plugins: [ | ||
new CleanWebpackPlugin(['dist']), | ||
new HtmlWebpackPlugin({ | ||
title: 'Caching' | ||
title: 'Caching' | ||
}), | ||
+ new webpack.HashedModuleIdsPlugin(), | ||
new webpack.optimize.CommonsChunkPlugin({ | ||
name: 'vendor' | ||
}), | ||
new webpack.optimize.CommonsChunkPlugin({ | ||
name: 'manifest' | ||
}) | ||
+ new webpack.HashedModuleIdsPlugin() | ||
], | ||
output: { | ||
filename: '[name].[chunkhash].js', | ||
path: path.resolve(__dirname, 'dist') | ||
}, | ||
optimization: { | ||
runtimeChunk: 'single', | ||
splitChunks: { | ||
cacheGroups: { | ||
vendor: { | ||
test: /[\\/]node_modules[\\/]/, | ||
name: 'vendors', | ||
chunks: 'all' | ||
} | ||
} | ||
} | ||
} | ||
}; | ||
``` | ||
|
||
Now, despite any new local dependencies, our `vendor` hash should stay consistent between builds: | ||
|
||
``` bash | ||
Hash: 1f49b42afb9a5acfbaff | ||
Version: webpack 3.3.0 | ||
Time: 1372ms | ||
Asset Size Chunks Chunk Names | ||
vendor.eed6dcc3b30cfa138aaa.js 541 kB 0 [emitted] [big] vendor | ||
main.d103ac311788fcb7e329.js 1.22 kB 1 [emitted] main | ||
manifest.d2a6dc1ccece13f5a164.js 5.85 kB 2 [emitted] manifest | ||
index.html 352 bytes [emitted] | ||
[3Di9] ./src/print.js 62 bytes {1} [built] | ||
[3IRH] (webpack)/buildin/module.js 517 bytes {0} [built] | ||
[DuR2] (webpack)/buildin/global.js 509 bytes {0} [built] | ||
[0] multi lodash 28 bytes {0} [built] | ||
[lVK7] ./src/index.js 421 bytes {1} [built] | ||
Hash: 17c37ce65c84b8ed5eb8 | ||
Version: webpack 4.16.2 | ||
Time: 637ms | ||
Built at: 2018-07-24 18:32:46 | ||
Asset Size Chunks Chunk Names | ||
main.216e852f60c8829c2289.js 340 bytes 0 [emitted] main | ||
vendors.55e79e5927a639d21a1b.js 69.5 KiB 1 [emitted] vendors | ||
runtime.725a1a51ede5ae0cfde0.js 1.42 KiB 2 [emitted] runtime | ||
index.html 353 bytes [emitted] | ||
Entrypoint main = runtime.725a1a51ede5ae0cfde0.js vendors.55e79e5927a639d21a1b.js main.216e852f60c8829c2289.js | ||
[YuTi] (webpack)/buildin/module.js 497 bytes {1} [built] | ||
[tjUo] ./src/index.js + 1 modules 408 bytes {0} [built] | ||
| ./src/index.js 341 bytes [built] | ||
| ./src/print.js 62 bytes [built] | ||
[yLpj] (webpack)/buildin/global.js 489 bytes {1} [built] | ||
+ 1 hidden module | ||
Child html-webpack-plugin for "index.html": | ||
1 asset | ||
Entrypoint undefined = index.html | ||
[YuTi] (webpack)/buildin/module.js 497 bytes {0} [built] | ||
[yLpj] (webpack)/buildin/global.js 489 bytes {0} [built] | ||
+ 2 hidden modules | ||
``` | ||
|
||
And let's modify our `src/index.js` to temporarily remove that extra dependency: | ||
|
@@ -364,22 +366,29 @@ __src/index.js__ | |
And finally run our build again: | ||
|
||
``` bash | ||
Hash: 37e1358f135c0b992f72 | ||
Version: webpack 3.3.0 | ||
Time: 1557ms | ||
Asset Size Chunks Chunk Names | ||
vendor.eed6dcc3b30cfa138aaa.js 541 kB 0 [emitted] [big] vendor | ||
main.fc7f38e648da79db2aba.js 891 bytes 1 [emitted] main | ||
manifest.bb5820632fb66c3fb357.js 5.85 kB 2 [emitted] manifest | ||
index.html 352 bytes [emitted] | ||
[3IRH] (webpack)/buildin/module.js 517 bytes {0} [built] | ||
[DuR2] (webpack)/buildin/global.js 509 bytes {0} [built] | ||
[0] multi lodash 28 bytes {0} [built] | ||
[lVK7] ./src/index.js 427 bytes {1} [built] | ||
Hash: 70fb9e00dee0bada797d | ||
Version: webpack 4.16.2 | ||
Time: 875ms | ||
Built at: 2018-07-24 18:33:50 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
Asset Size Chunks Chunk Names | ||
main.ad717f2466ce655fff5c.js 274 bytes 0 [emitted] main | ||
vendors.55e79e5927a639d21a1b.js 69.5 KiB 1 [emitted] vendors | ||
runtime.725a1a51ede5ae0cfde0.js 1.42 KiB 2 [emitted] runtime | ||
index.html 353 bytes [emitted] | ||
Entrypoint main = runtime.725a1a51ede5ae0cfde0.js vendors.55e79e5927a639d21a1b.js main.ad717f2466ce655fff5c.js | ||
[YuTi] (webpack)/buildin/module.js 497 bytes {1} [built] | ||
[tjUo] ./src/index.js 347 bytes {0} [built] | ||
[yLpj] (webpack)/buildin/global.js 489 bytes {1} [built] | ||
+ 1 hidden module | ||
Child html-webpack-plugin for "index.html": | ||
1 asset | ||
Entrypoint undefined = index.html | ||
[YuTi] (webpack)/buildin/module.js 497 bytes {0} [built] | ||
[yLpj] (webpack)/buildin/global.js 489 bytes {0} [built] | ||
+ 2 hidden modules | ||
``` | ||
|
||
We can see that both builds yielded `eed6dcc3b30cfa138aaa` in the `vendor` bundle's filename. | ||
We can see that both builds yielded `55e79e5927a639d21a1b` in the `vendor` bundle's filename. | ||
|
||
|
||
## Conclusion | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont include date into logs