Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to webpack 4 #2389

Merged
merged 6 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@afontcu
Copy link
Contributor

commented Jul 24, 2018

Hi! 馃憢 This PR fixes #2296

Following is a list of removed resources and a brief explanation of the reasons behind:

  • Predictable Long Term Caching
    Based on webpack 3 (i.e. code snippets use CommonsChunkPlugin)

  • Webpack & Caching
    While some of the recommendations might still be useful, some other make use CommonsChunkPlugin. Maybe the reference could be updated and then kept in the docs?

  • Advanced Webpack Presentation
    Based on webpack 3 (i.e. code snippets use CommonsChunkPlugin)

  • Issue 1315
    Issue created on 2015 and closed this May. Might be relevant to webpack 4 to a certain extent, but does not provide valid answers.


This is my first PR, so all feedback is really appreciated. Thanks for your patience!

@montogeek montogeek requested a review from EugeneHlushko Jul 24, 2018

@EugeneHlushko
Copy link
Member

left a comment

Minor change and and its good

Hash: 17c37ce65c84b8ed5eb8
Version: webpack 4.16.2
Time: 637ms
Built at: 2018-07-24 18:32:46

This comment has been minimized.

Copy link
@EugeneHlushko

EugeneHlushko Jul 25, 2018

Member

we dont include date into logs

Hash: 70fb9e00dee0bada797d
Version: webpack 4.16.2
Time: 875ms
Built at: 2018-07-24 18:33:50

This comment has been minimized.

Copy link
@EugeneHlushko

EugeneHlushko Jul 25, 2018

Member

same

@afontcu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2018

Thanks! Dates removed from logs 馃檶

@montogeek montogeek added the Guides label Jul 27, 2018

montogeek and others added some commits Jul 27, 2018

@montogeek montogeek merged commit cf461fe into webpack:master Jul 30, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@montogeek

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

Thanks!

@afontcu afontcu deleted the afontcu:patch-5 branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.