Update references to webpack 4 #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneHlushko
requested changes
Jul 25, 2018
src/content/guides/caching.md
Outdated
| Hash: 17c37ce65c84b8ed5eb8 | ||
| Version: webpack 4.16.2 | ||
| Time: 637ms | ||
| Built at: 2018-07-24 18:32:46 |
There was a problem hiding this comment.
we dont include date into logs
src/content/guides/caching.md
Outdated
| Hash: 70fb9e00dee0bada797d | ||
| Version: webpack 4.16.2 | ||
| Time: 875ms | ||
| Built at: 2018-07-24 18:33:50 |
|
Thanks! Dates removed from logs 🙌 |
EugeneHlushko
approved these changes
Jul 25, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 This PR fixes #2296
Following is a list of removed resources and a brief explanation of the reasons behind:
Predictable Long Term Caching
Based on webpack 3 (i.e. code snippets use CommonsChunkPlugin)
Webpack & Caching
While some of the recommendations might still be useful, some other make use CommonsChunkPlugin. Maybe the reference could be updated and then kept in the docs?
Advanced Webpack Presentation
Based on webpack 3 (i.e. code snippets use CommonsChunkPlugin)
Issue 1315
Issue created on 2015 and closed this May. Might be relevant to webpack 4 to a certain extent, but does not provide valid answers.
This is my first PR, so all feedback is really appreciated. Thanks for your patience!