Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stronger check and override of comments in UglifyJsPlugin options #1298

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Stronger check and override of comments in UglifyJsPlugin options #1298

merged 1 commit into from
Jul 27, 2015

Conversation

dashed
Copy link
Contributor

@dashed dashed commented Jul 25, 2015

Fixes #324

@dashed dashed mentioned this pull request Jul 25, 2015
Closed
@sokra
Copy link
Member

sokra commented Jul 25, 2015

Could you add a test for this?

@dashed
Copy link
Contributor Author

dashed commented Jul 25, 2015

Sure. Do I add it in /test/configCases/plugins?

@sokra
Copy link
Member

sokra commented Jul 26, 2015

yep

@dashed
Copy link
Contributor Author

dashed commented Jul 27, 2015

@sokra Added test and rebased.

sokra added a commit that referenced this pull request Jul 27, 2015
@sokra
Merge pull request #1298 from Dashed/patch-1
7c5da65 
Stronger check and override of comments in UglifyJsPlugin options
@sokra sokra merged commit 7c5da65 into webpack:master Jul 27, 2015
@sokra
Copy link
Member

sokra commented Jul 27, 2015

Thanks, great PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashed @sokra