Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect tsd #535

Closed
voxpelli opened this issue Mar 8, 2024 · 6 comments
Closed

Auto-detect tsd #535

voxpelli opened this issue Mar 8, 2024 · 6 comments
Labels
feature request Feature request

Comments

@voxpelli
Copy link
Contributor

voxpelli commented Mar 8, 2024

Would be sweet if knip auto-detected tsd and automatically detected .test-d.ts files as used then :)

It didn't for me when I added tsd in a project that uses knip@5.0.3

@voxpelli voxpelli added the feature request Feature request label Mar 8, 2024
@webpro
Copy link
Collaborator

webpro commented Mar 11, 2024

Sounds like a feature request for a tsd plugin :)

@voxpelli
Copy link
Contributor Author

Oh, I should maybe have added it to #483 instead of creating a new issue, my bad 🙈

I'll try to make a PR for one once the plugin work you seems to be up to in the plugins branch is done 🙂

@webpro
Copy link
Collaborator

webpro commented Mar 11, 2024

Oh, I should maybe have added it to #483 instead of creating a new issue, my bad 🙈

Sorry, didn't mean to hint that YOU should do that.

I'll try to make a PR for one once the plugin work you seems to be up to in the plugins branch is done 🙂

Good call, was busy with that indeed: #540

@webpro
Copy link
Collaborator

webpro commented Mar 24, 2024

Feel free to open a PR obviously, just trying to clean up the list of open issues.

@voxpelli
Copy link
Contributor Author

@webpro And I actually moved away from using tsd myself and maybe we will even do so in type-fest 🙈

@webpro
Copy link
Collaborator

webpro commented Mar 24, 2024

Oof, good to know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants