-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for package self-referencing #88
Conversation
5d22d94
to
b0949af
Compare
b46edc9
to
e0e96ec
Compare
e0e96ec
to
c0eb7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about self-referencing a package using its name :) Hats off for picking this up in this oddly organized codebase, including tests & fixtures! Also glad you worked against v2.
tests/fixtures/self-reference/node_modules/@sindresorhus/is/index.js
Outdated
Show resolved
Hide resolved
The windows test seems to be failing due to upstream issue. |
Yes, facing this too:
|
e1add0a
to
9e2d849
Compare
I opened RebeccaStevens#1 to better describe what I meant and added some comments in the code as well. Did you see that? Perhaps a bit odd to open a PR this way, but alas :) |
9e2d849
to
71c8961
Compare
abfe6ce
to
c076899
Compare
f4ca22c
to
91f1ecd
Compare
Alright, let's go! I'm very grateful for your efforts @RebeccaStevens |
fix #87