Copy assets specified in YAML Front matter for a static build #279
Conversation
|
Thanks @jnv! What I'm seeing now is that the "tomorrow-night-bright" highlight styles are copied properly, but the theme is not actually used in the exported version (it still uses the default "zenburn"). The "night" theme is also available in the export, but not used. |
|
@webpro Thanks for checking that out. Maybe I am missing something or there's another issue, as I cannot reproduce that problem either. I have converted cd reveal-md
rm -rf _static
reveal-md demo/e.md --staticI do get the correct highlight theme in the generated And the generated <title>Custom Options With Frontmatter</title>
<link rel="stylesheet" href="./css/reveal.css" />
<link rel="stylesheet" href="./css/theme/night.css" id="theme" />
<link rel="stylesheet" href="./css/highlight/tomorrow-night-bright.css" />So both the theme and highlight theme are correctly linked in my case. I have no idea why it's not working in your case; what OS and Node version are you using? Maybe I can try to create similar testing conditions. Or maybe there's some caching? 🤔 |
|
I'm sorry @jnv, when executing Let's see later if we can simplify |
This is a follow-up to #265 which got recently closed.
I was unable to reproduce the issue with linking. I am on macOS 10.15 with Node v10.17.0 (I have also tried v12.12.0 with the same result).
My suspicion is that maybe we are not awaiting for the whole array of promises from
copyAssetsAndWriteFileto resolve, so I have addedPromise.allaround the return value. Other than that I have rebased the PR, removed unnecessaryasync, and added an example todemofolder. Most of the hard work has been already done by @lukaszkostrzewa, I would just like to help to get this fix through.