Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA Manifest Not Available on Deployed Site #251

Closed
Shrinks99 opened this issue Oct 6, 2023 · 0 comments · Fixed by #253
Closed

PWA Manifest Not Available on Deployed Site #251

Shrinks99 opened this issue Oct 6, 2023 · 0 comments · Fixed by #253
Assignees
@Shrinks99
Labels
bug Something isn't working
Milestone
ReplayWeb.Page Em...

Comments

@Shrinks99
Copy link
Member

ReplayWebpage currently has a PWA manifest but it's not currently linked to in the head of https://replayweb.page!

When running the dev server locally with yarn run start-dev it is available. The deployed version doesn't seem to includ the same information in the head section of index.html.
@Shrinks99 Shrinks99 added the bug Something isn't working label Oct 6, 2023
@Shrinks99 Shrinks99 added this to the ReplayWeb.Page Embed v2.0.0 milestone Oct 6, 2023
@Shrinks99 Shrinks99 self-assigned this Oct 6, 2023
ikreymer added a commit that referenced this issue Oct 6, 2023
@ikreymer
fix: ensure default index.html is served for app, only serve wabac.js…
906464e 
… index page when in embed mode, fixes #251

bump to 1.8.13
@ikreymer ikreymer mentioned this issue Oct 6, 2023
Merged
ikreymer added a commit that referenced this issue Oct 6, 2023
@ikreymer
fix: ensure default index.html is served for app, only serve wabac.js…
31dbe00 
… index page when in embed mode, fixes #251 (#253)

bump to 1.8.13
emma-sg pushed a commit that referenced this issue Nov 29, 2023
@ikreymer @emma-sg
fix: ensure default index.html is served for app, only serve wabac.js…
c7b2fd7 
… index page when in embed mode, fixes #251 (#253)

bump to 1.8.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shrinks99 Shrinks99

Labels
bug Something isn't working
Projects
Webrecorder Projects
Status: Done!
Milestone
ReplayWeb.Page Embed v2.0.0
Development

Successfully merging a pull request may close this issue.

fix: ensure default index.html is served for app, webrecorder/replayweb.page
1 participant
@Shrinks99