Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filetransfer sample doesn't use bufferedAmountLow #872

Closed
fippo opened this issue Feb 4, 2017 · 1 comment
Closed

filetransfer sample doesn't use bufferedAmountLow #872

fippo opened this issue Feb 4, 2017 · 1 comment

Comments

@fippo
Copy link
Collaborator

fippo commented Feb 4, 2017

https://github.com/webrtc/samples/blob/gh-pages/src/content/datachannel/filetransfer/js/main.js
doesn't use the bufferedAmountLow callback. It should, like the datatransfer one does.

cc @taylor-b :-)

@ErikHellman ErikHellman self-assigned this Jul 18, 2018
@ErikHellman ErikHellman removed their assignment Aug 7, 2018
@ErikHellman
Copy link
Contributor

Since we're using a FileReader and the load event from that, it becomes tricky to also use bufferedamountlow event.

I'm closing this since the sample works well at the moment and there is no need to use this event. Also ,there seems to be some problems with that event at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants