fixed parsing of parametric mixins & update ESLint dependencies #27
Conversation
| const root = parse('.foo(@bar) { color: @bar;}', {mixinsAsAtRules: true, innerMixinsAsRules: true}); | ||
|
|
||
| expect(root.first.type).to.eql('atrule'); | ||
| expect(root.first.params[0].type).to.eql('atrule'); |
There was a problem hiding this comment.
eesh. disagree with that choice. adding lessType is just conflating what the syntax is supposed to handle. the entire purpose of a postcss syntax is to direct the parser on how to handle language-specific elements. all this does is tell the parser to continue on as normal while adding a tiny bit of metadata.
also, params should contain the same container convenience methods, or be inserted as child nodes.
There was a problem hiding this comment.
We would like to handle many LESS features: params, all types of mixins, 'rest' params, etc. At the same time PostCSS supports a few syntax constructions: Declarations, AtRules, Rules, Comments. So I try to parse LESS within these limits and the things like 'lessType' are hacks to provide some additional capabilities for 3rd-party libraries.
There was a problem hiding this comment.
going down that road will mean that postcss-less is a monkeypatch (not in a bad sense at all) more than a true syntax (postcss-scss for example, is a true syntax). if that's your plan moving forward, please consider renaming the module and opening the door for a true syntax in the future.
There was a problem hiding this comment.
@shellscape, I see your point. I think you're right, I have to extend the parsed tree from postcss-less and use not only nodes from API of PostCSS, but all custom nodes should have similar syntax and structure as nodes AtRule, Rule, etc. I think it will be done in the next version of postcss-less
There was a problem hiding this comment.
@patsissons, what do you think about it, especially from Stylelint side?
I propose to add custom MixinNode (similar to AtRule or Rule in PostCSS), MixinParam (maybe similar to Declaration in PostCSS), ExtendNode (~Rule) nodes and extend stringifier of postcss-less.
No description provided.