Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why scaleFactor and not devicePixelRatio? #29

Closed
jakearchibald opened this issue Sep 14, 2020 · 4 comments
Closed

Why scaleFactor and not devicePixelRatio? #29

jakearchibald opened this issue Sep 14, 2020 · 4 comments
Assignees
@michaelwasserman

Comments

@jakearchibald
Copy link

I know devicePixelRatio isn't a great name, but it's the name we have.
@michaelwasserman michaelwasserman self-assigned this Sep 15, 2020
@michaelwasserman
Copy link
Member

This is a fair suggestion; I'll update the proposal soon.

@kenchris
Copy link

https://wicg.github.io/visual-viewport/ uses "scale" oh joy

@jakearchibald
Copy link
Author

That isn't the pixel ratio of the device though, so it'd right to use a different name. It's only impacted by zooming within the page viewport.

@michaelwasserman michaelwasserman mentioned this issue Oct 9, 2020
Merged
@michaelwasserman
Copy link
Member

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelwasserman michaelwasserman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakearchibald @kenchris @michaelwasserman