Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "close" method in Sender.hixie #37

Closed
nicokaiser opened this issue Mar 5, 2012 · 1 comment
Closed

Missing "close" method in Sender.hixie #37

nicokaiser opened this issue Mar 5, 2012 · 1 comment

Comments

@nicokaiser
Copy link
Contributor

The hixie version of the Sender seems to lack the "close" method. Maybe the other methods (like ping, etc.) should be in Sender.hixie as well?

I'm getting this on a server with only hixie connections:

payload must start with 0x00 byte
TypeError: Object # has no method 'close'

Seems like after a broken packet (e.g. connection broken by a proxy) the server wants to fire the connection's "close" method, which does not exist..

@einaros
Copy link
Contributor

einaros commented Mar 5, 2012

You're right. Strange that I missed that one. Will add to next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants