Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender.Hixie ignores the fin flag #70

Closed
kersam-bl opened this issue May 9, 2012 · 1 comment
Closed

Sender.Hixie ignores the fin flag #70

kersam-bl opened this issue May 9, 2012 · 1 comment

Comments

@kersam-bl
Copy link

The Sender.Hixie's send() method simply ignores the fin flag.
This leads to incomplete frames when using Websockets.stream() or send() with a read stream.
Suggested fix:
Write the final FF byte only when fin === true, write the initial 00 byte only when the last frame was terminated.

@einaros
Copy link
Contributor

einaros commented May 19, 2012

I've included a fix for this in the latest release, which will be pushed soon. Thank you!

@einaros einaros closed this as completed May 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants